* [patch] 64 bit bug in ohci1394.c
@ 2001-08-16 4:42 jes
0 siblings, 0 replies; 2+ messages in thread
From: jes @ 2001-08-16 4:42 UTC (permalink / raw)
To: sebastien.rougeaux; +Cc: Gord Peters, torvalds, alan, linux-kernel
Hi
drivers/ieee1394/ohci1394.c has a couple of instances where it saved
cpu flags in 'int' which breaks on 64 bit boxes.
Here's a patch.
Jes
--- drivers/ieee1394/ohci1394.c~ Wed Aug 8 00:08:04 2001
+++ drivers/ieee1394/ohci1394.c Thu Aug 16 00:40:28 2001
@@ -200,7 +200,8 @@
static u8 get_phy_reg(struct ti_ohci *ohci, u8 addr)
{
- int i, flags;
+ int i;
+ unsigned long flags;
quadlet_t r;
spin_lock_irqsave (&ohci->phy_reg_lock, flags);
@@ -227,7 +228,8 @@
static void set_phy_reg(struct ti_ohci *ohci, u8 addr, u8 data)
{
- int i, flags;
+ int i;
+ unsigned long flags;
u32 r;
spin_lock_irqsave (&ohci->phy_reg_lock, flags);
@@ -1066,7 +1068,8 @@
quadlet_t event, node_id;
struct ti_ohci *ohci = (struct ti_ohci *)dev_id;
struct hpsb_host *host = ohci->host;
- int phyid = -1, isroot = 0, flags;
+ int phyid = -1, isroot = 0;
+ unsigned long flags;
/* Read the interrupt event register. We don't clear the bus reset
* here. We wait till we get a selfid complete interrupt and clear
@@ -1331,7 +1334,8 @@
struct ti_ohci *ohci = (struct ti_ohci*)(d->ohci);
unsigned int split_left, idx, offset, rescount;
unsigned char tcode;
- int length, bytes_left, ack, flags;
+ int length, bytes_left, ack;
+ unsigned long flags;
quadlet_t *buf_ptr;
char *split_ptr;
char msg[256];
^ permalink raw reply [flat|nested] 2+ messages in thread
* [patch] 64 bit bug in ohci1394.c
@ 2001-08-16 4:44 jes
0 siblings, 0 replies; 2+ messages in thread
From: jes @ 2001-08-16 4:44 UTC (permalink / raw)
To: jamesg; +Cc: torvalds, alan, linux-kernel
Hi
drivers/ieee1394/sbp.c has a couple of instances where it saved
cpu flags in 'int' which breaks on 64 bit boxes.
Here's a patch.
Jes
--- drivers/ieee1394/sbp2.c~ Wed Aug 8 00:08:04 2001
+++ drivers/ieee1394/sbp2.c Thu Aug 16 00:43:54 2001
@@ -984,7 +984,7 @@
static void sbp2_add_host(struct hpsb_host *host)
{
struct sbp2scsi_host_info *hi;
- unsigned int flags;
+ unsigned long flags;
SBP2_DEBUG("sbp2: sbp2_add_host");
@@ -1067,7 +1067,7 @@
{
struct sbp2scsi_host_info *hi;
int i;
- unsigned int flags;
+ unsigned long flags;
SBP2_DEBUG("sbp2: sbp2_remove_host");
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-08-16 4:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-08-16 4:42 [patch] 64 bit bug in ohci1394.c jes
2001-08-16 4:44 jes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®