[PATCH] usb fix

[PATCH] usb fix

[Andries.Brouwer]

Wondering why my USB Compact Flash cardreader works with 2.4.7
but not with 2.4.9, I noticed that my name was added and some
constant changed. Changing it back revived my CF reader.

Andries

--- ../linux-2.4.9/linux/drivers/usb/storage/unusual_devs.h	Sat Aug 11 03:16:46 2001
+++ ./linux/drivers/usb/storage/unusual_devs.h	Fri Aug 31 23:50:19 2001
@@ -96,7 +96,7 @@
 #endif
 
 /* This entry is from Andries.Brouwer@cwi.nl */
-UNUSUAL_DEV(  0x04e6, 0x0005, 0x0100, 0x0205, 
+UNUSUAL_DEV(  0x04e6, 0x0005, 0x0100, 0x0208,
 		"SCM Microsystems",
 		"eUSB SmartMedia / CompactFlash Adapter",
 		US_SC_SCSI, US_PR_DPCM_USB, NULL, 

Re: [PATCH] usb fix

[Matthew Dharm]

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

Odd.... must have been some sort of merging error on my part.  Sorry about
that.

Alan, Linus, this looks fine.

Matt

On Fri, Aug 31, 2001 at 10:03:27PM +0000, Andries.Brouwer@cwi.nl wrote:
> Wondering why my USB Compact Flash cardreader works with 2.4.7
> but not with 2.4.9, I noticed that my name was added and some
> constant changed. Changing it back revived my CF reader.
> 
> Andries
> 
> --- ../linux-2.4.9/linux/drivers/usb/storage/unusual_devs.h	Sat Aug 11 03:16:46 2001
> +++ ./linux/drivers/usb/storage/unusual_devs.h	Fri Aug 31 23:50:19 2001
> @@ -96,7 +96,7 @@
>  #endif
>  
>  /* This entry is from Andries.Brouwer@cwi.nl */
> -UNUSUAL_DEV(  0x04e6, 0x0005, 0x0100, 0x0205, 
> +UNUSUAL_DEV(  0x04e6, 0x0005, 0x0100, 0x0208,
>  		"SCM Microsystems",
>  		"eUSB SmartMedia / CompactFlash Adapter",
>  		US_SC_SCSI, US_PR_DPCM_USB, NULL, 

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

DP: And judging from the scores, Stef has the sma...  
T:  LET'S NOT GO THERE!
					-- Dust Puppy and Tanya
User Friendly, 12/11/1997

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [PATCH] usb fix

[Alan Cox]

> 
> 
> --LyciRD1jyfeSSjG0
> Content-Type: text/plain; charset=us-ascii
> Content-Disposition: inline
> Content-Transfer-Encoding: quoted-printable
> 
> Odd.... must have been some sort of merging error on my part.  Sorry about
> that.
> 
> Alan, Linus, this looks fine.
> 
> Matt
> 
> On Fri, Aug 31, 2001 at 10:03:27PM +0000, Andries.Brouwer@cwi.nl wrote:
> > Wondering why my USB Compact Flash cardreader works with 2.4.7
> > but not with 2.4.9, I noticed that my name was added and some
> > constant changed. Changing it back revived my CF reader.
> >=20
> > Andries
> >=20
> > --- ../linux-2.4.9/linux/drivers/usb/storage/unusual_devs.h	Sat Aug 11 03=
> :16:46 2001
> > +++ ./linux/drivers/usb/storage/unusual_devs.h	Fri Aug 31 23:50:19 2001
> > @@ -96,7 +96,7 @@
> >  #endif
> > =20
> >  /* This entry is from Andries.Brouwer@cwi.nl */
> > -UNUSUAL_DEV(  0x04e6, 0x0005, 0x0100, 0x0205,=20
> > +UNUSUAL_DEV(  0x04e6, 0x0005, 0x0100, 0x0208,
> >  		"SCM Microsystems",
> >  		"eUSB SmartMedia / CompactFlash Adapter",
> >  		US_SC_SCSI, US_PR_DPCM_USB, NULL,=20
> 
> --=20
> Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.=
> net=20
> Maintainer, Linux USB Mass Storage Driver
> 
> DP: And judging from the scores, Stef has the sma... =20
> T:  LET'S NOT GO THERE!
> 					-- Dust Puppy and Tanya
> User Friendly, 12/11/1997
> 
> --LyciRD1jyfeSSjG0
> Content-Type: application/pgp-signature
> Content-Disposition: inline
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.0.6 (GNU/Linux)
> Comment: For info see http://www.gnupg.org
> 
> iD8DBQE7kAzEz64nssGU+ykRAsXWAJ43l0buh6V5Xq/Wtd3cbi6EUUB+pQCdHeAM
> y600l6YtDePtP/TMub27qlg=
> =91SG
> -----END PGP SIGNATURE-----
> 
> --LyciRD1jyfeSSjG0--
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Re: [PATCH] usb fix

[Alan Cox]

> but not with 2.4.9, I noticed that my name was added and some
> constant changed. Changing it back revived my CF reader.

Yes you added the entry, someone changed the constant as it didnt work
for them, now you change it back.

I suspect both constants should be in 8)

Re: [PATCH] usb fix

[Matthew Dharm]

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

That doesn't sound right, Alan...

The constant in question is an upper-limit to the range of device versions
what get accepted.  Narrowing the range can only break things -- making it
wider may not (necessarily) fix anything, but it does increase the scope of
the entry.

I'm guessing that someone meant to change it from something smaller than
either Andries' or the current value to where it is now, but the larger
value (i.e. Andries') is the proper one.

Matt

On Fri, Aug 31, 2001 at 11:19:01PM +0100, Alan Cox wrote:
> > but not with 2.4.9, I noticed that my name was added and some
> > constant changed. Changing it back revived my CF reader.
> 
> Yes you added the entry, someone changed the constant as it didnt work
> for them, now you change it back.
> 
> I suspect both constants should be in 8)

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

We can customize our colonels.
					-- Tux
User Friendly, 12/1/1998

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

Re: [PATCH] usb fix

[Alan Cox]

> That doesn't sound right, Alan...
> 
> The constant in question is an upper-limit to the range of device versions
> what get accepted.  Narrowing the range can only break things -- making it
> wider may not (necessarily) fix anything, but it does increase the scope of
> the entry.
> 

You are indeed correct.