mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Gooch <rgooch@ras.ucalgary.ca>
To: torvalds@transmeta.com, crutcher+kernel@datastacks.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] for drivers/char/sysrq.c
Date: Wed, 19 Sep 2001 21:45:37 -0600	[thread overview]
Message-ID: <200109200345.f8K3jbr29597@vindaloo.ras.ucalgary.ca> (raw)

  Hi, Linus. The appended patch fixes drivers/char/sysrq.c so that it
doesn't do a bugus redefine of wakeup_bdflush(), nor attempt to pass
arguments to it. The changes in 2.4.10-pre12 broke sysrq.c compiling.

<whinge>
How did something this basic get submitted in the first place?!?
Doesn't anyone bother compiling patches before sending to Linus?
This is the second time today I've had to patch the kernel just to get
the rotten thing to compile. I'm not happy that whoever put in those
__builtin_expect()'s didn't bother testing with THE RECOMMENDED
COMPILER!!! It's not the first time that sort of thing has happened.
</whinge>

				Regards,

					Richard....
Permanent: rgooch@atnf.csiro.au
Current:   rgooch@ras.ucalgary.ca

--- sysrq.c~	Wed Sep 19 21:25:45 2001
+++ sysrq.c	Wed Sep 19 21:37:31 2001
@@ -32,7 +32,6 @@
 
 #include <asm/ptrace.h>
 
-extern void wakeup_bdflush(int);
 extern void reset_vc(unsigned int);
 extern struct list_head super_blocks;
 
@@ -221,7 +220,7 @@
 static void sysrq_handle_sync(int key, struct pt_regs *pt_regs,
 		struct kbd_struct *kbd, struct tty_struct *tty) {
 	emergency_sync_scheduled = EMERG_SYNC;
-	wakeup_bdflush(0);
+	wakeup_bdflush();
 }
 static struct sysrq_key_op sysrq_sync_op = {
 	handler:	sysrq_handle_sync,
@@ -232,7 +231,7 @@
 static void sysrq_handle_mountro(int key, struct pt_regs *pt_regs,
 		struct kbd_struct *kbd, struct tty_struct *tty) {
 	emergency_sync_scheduled = EMERG_REMOUNT;
-	wakeup_bdflush(0);
+	wakeup_bdflush();
 }
 static struct sysrq_key_op sysrq_mountro_op = {
 	handler:	sysrq_handle_mountro,

             reply	other threads:[~2001-09-20  3:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-20  3:45 Richard Gooch [this message]
2001-09-20 12:38 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200109200345.f8K3jbr29597@vindaloo.ras.ucalgary.ca \
    --to=rgooch@ras.ucalgary.ca \
    --cc=crutcher+kernel@datastacks.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®