From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: rgooch@ras.ucalgary.ca (Richard Gooch)
Cc: torvalds@transmeta.com, crutcher+kernel@datastacks.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] for drivers/char/sysrq.c
Date: Thu, 20 Sep 2001 13:38:16 +0100 (BST) [thread overview]
Message-ID: <E15k35s-0005C3-00@the-village.bc.nu> (raw)
In-Reply-To: <200109200345.f8K3jbr29597@vindaloo.ras.ucalgary.ca> from "Richard Gooch" at Sep 19, 2001 09:45:37 PM
> How did something this basic get submitted in the first place?!?
> Doesn't anyone bother compiling patches before sending to Linus?
> This is the second time today I've had to patch the kernel just to get
> the rotten thing to compile. I'm not happy that whoever put in those
> __builtin_expect()'s didn't bother testing with THE RECOMMENDED
> COMPILER!!! It's not the first time that sort of thing has happened.
> </whinge>
It got broken because the stable kernel API isnt. When I submitted it to
Linus I missed one specific random api of the week variance. Its been in
the -ac tree and vendor distros for a while, so it was tested.
Alan
prev parent reply other threads:[~2001-09-20 12:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-20 3:45 Richard Gooch
2001-09-20 12:38 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E15k35s-0005C3-00@the-village.bc.nu \
--to=alan@lxorguk.ukuu.org.uk \
--cc=crutcher+kernel@datastacks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rgooch@ras.ucalgary.ca \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®