Re: Linux-2.4.10 - necessary patches

Re: Linux-2.4.10 - necessary patches

[Stephen Cameron]

Alan Cox wrote:

> > +/* Used to invoke Target Defice Reset for Fibre Channel */
> > +#define SCSI_IOCTL_FC_TDR 0x5388
> > +
> > +/* Used to get Fibre Channel WWN and port_id from device */
> > +#define SCSI_IOCTL_FC_TARGET_ADDRESS 0x5389
> > +
? 
? These are compaq made up ioctls. They shouldnt be merged like that. Instead
? there needs to be proper discussion about what is actualyl needed

Would it help to move these into a cpqfc specific header file? I'm
making changes to cpqfc already anyway (to use new DMA interfaces) so
I oculd move those ioctls while I was at it.

-- steve (aka steve.cameron@compaq.com)


__________________________________________________
Do You Yahoo!?
Get email alerts & NEW webcam video instant messaging with Yahoo! Messenger. http://im.yahoo.com

Re: Linux-2.4.10 - necessary patches

[Alan Cox]

> Would it help to move these into a cpqfc specific header file? I'm
> making changes to cpqfc already anyway (to use new DMA interfaces) so
> I oculd move those ioctls while I was at it.

Probably a good idea for the moment. The problem is those ioctl values
might get issued for something else. Really we need a 'device private'
range for scsi ioctls or something

Re: Linux-2.4.10 - necessary patches

[Oliver Xymoron]

On Mon, 24 Sep 2001, Alan Cox wrote:

> > --- linux-2.4.10-pre7/include/scsi/scsi.h	Fri Apr 27 13:59:19 2001
> > +++ linux/include/scsi/scsi.h	Mon Sep 10 03:53:58 2001
> > @@ -214,6 +214,12 @@
> >  /* Used to get the PCI location of a device */
> >  #define SCSI_IOCTL_GET_PCI 0x5387
> >
> > +/* Used to invoke Target Defice Reset for Fibre Channel */
> > +#define SCSI_IOCTL_FC_TDR 0x5388
> > +
> > +/* Used to get Fibre Channel WWN and port_id from device */
> > +#define SCSI_IOCTL_FC_TARGET_ADDRESS 0x5389
> > +
>
> These are compaq made up ioctls. They shouldnt be merged like that. Instead
> there needs to be proper discussion about what is actualyl needed

And please, not ioctl(). iSCSI (SCSI-over-IP) is going to require similar
per-device information (this info isn't FC-specific), but probably a lot
more. Adding a dozen ioctls is bad. At least one of the current iSCSI
drivers puts this info in /proc/scsi/iscsi.

--
 "Love the dolphins," she advised him. "Write by W.A.S.T.E.."

Re: Linux-2.4.10 - necessary patches

[Alan Cox]

> 
> --- linux-2.4.10-pre7/include/scsi/scsi.h	Fri Apr 27 13:59:19 2001
> +++ linux/include/scsi/scsi.h	Mon Sep 10 03:53:58 2001
> @@ -214,6 +214,12 @@
>  /* Used to get the PCI location of a device */
>  #define SCSI_IOCTL_GET_PCI 0x5387
>  
> +/* Used to invoke Target Defice Reset for Fibre Channel */
> +#define SCSI_IOCTL_FC_TDR 0x5388
> +
> +/* Used to get Fibre Channel WWN and port_id from device */
> +#define SCSI_IOCTL_FC_TARGET_ADDRESS 0x5389
> +

These are compaq made up ioctls. They shouldnt be merged like that. Instead
there needs to be proper discussion about what is actualyl needed

Re: Linux-2.4.10 - necessary patches

[Eyal Lebedinsky]

[-- Attachment #1: Type: text/plain, Size: 123 bytes --]

To build 2.4.10 I needed these two (old) patches.

--
Eyal Lebedinsky (eyal@eyal.emu.id.au) <http://samba.anu.edu.au/eyal/>

[-- Attachment #2: 2.4.10-aironet.patch --]
[-- Type: text/plain, Size: 274 bytes --]

--- linux/drivers/net/aironet4500_card.c.orig	Fri Sep 21 22:14:16 2001
+++ linux/drivers/net/aironet4500_card.c	Fri Sep 21 22:14:37 2001
@@ -17,6 +17,7 @@
 #endif
 
 #include <linux/version.h>
+#include <linux/init.h>
 #include <linux/config.h>
 #include <linux/module.h>
 

[-- Attachment #3: 2.4.10-cpqfc.patch --]
[-- Type: text/plain, Size: 902 bytes --]

--- linux-2.4.10-pre7/include/scsi/scsi.h	Fri Apr 27 13:59:19 2001
+++ linux/include/scsi/scsi.h	Mon Sep 10 03:53:58 2001
@@ -214,6 +214,12 @@
 /* Used to get the PCI location of a device */
 #define SCSI_IOCTL_GET_PCI 0x5387
 
+/* Used to invoke Target Defice Reset for Fibre Channel */
+#define SCSI_IOCTL_FC_TDR 0x5388
+
+/* Used to get Fibre Channel WWN and port_id from device */
+#define SCSI_IOCTL_FC_TARGET_ADDRESS 0x5389
+
 /*
  * Overrides for Emacs so that we follow Linus's tabbing style.
  * Emacs will notice this stuff at the end of the file and automatically
--- linux-2.4.10-pre7/drivers/scsi/cpqfcTSinit.c	Sun Aug 12 10:51:41 2001
+++ linux/drivers/scsi/cpqfcTSinit.c	Mon Sep 10 03:54:23 2001
@@ -63,6 +63,7 @@
 
 #include <linux/config.h>  
 #include <linux/module.h>
+#include <linux/init.h>
 #include <linux/version.h> 
 
 /* Embedded module documentation macros - see module.h */