[PATCH] ipip.c & ip_gre.c (Add Tunnel return)

[PATCH] ipip.c & ip_gre.c (Add Tunnel return)

[andrew may]

I think the tunnel drivers should return the name of the
device the tunnel add created. Currently the tunnel_lookup
functions copy the name into the stack var in the ioctl
function but the ioctl copies the parm from the tunnel
device.

--- linux.org/net/ipv4/ip_gre.c	Tue Sep 25 02:27:58 2001
+++ linux/net/ipv4/ip_gre.c	Tue Sep 25 02:34:03 2001
@@ -284,7 +284,7 @@
 		}
 		if (i==100)
 			goto failed;
-		memcpy(parms->name, dev->name, IFNAMSIZ);
+		memcpy(nt->parms.name, dev->name, IFNAMSIZ);
 	}
 	if (register_netdevice(dev) < 0)
 		goto failed;
diff -ur linux.org/net/ipv4/ipip.c linux/net/ipv4/ipip.c
--- linux.org/net/ipv4/ipip.c	Tue Sep 25 02:27:52 2001
+++ linux/net/ipv4/ipip.c	Tue Sep 25 02:32:59 2001
@@ -255,7 +255,7 @@
 		}
 		if (i==100)
 			goto failed;
-		memcpy(parms->name, dev->name, IFNAMSIZ);
+		memcpy(nt->parms.name, dev->name, IFNAMSIZ);
 	}
 	if (register_netdevice(dev) < 0)
 		goto failed;

Re: [PATCH] ipip.c & ip_gre.c (Add Tunnel return)

[David S. Miller]

   From: andrew may <acmay@acmay.homeip.net>
   Date: Tue, 25 Sep 2001 15:26:28 -0700

   I think the tunnel drivers should return the name of the
   device the tunnel add created. Currently the tunnel_lookup
   functions copy the name into the stack var in the ioctl
   function but the ioctl copies the parm from the tunnel
   device.
   
Hmmm, net/ipv6/sit.c already has the version you propose. :-)))
Which one is correct?

Alexey, what do you think?

Franks a lot,
David S. Miller
davem@redhat.com

Re: [PATCH] ipip.c & ip_gre.c (Add Tunnel return)

[David S. Miller]

   From: "David S. Miller" <davem@redhat.com>
   Date: Tue, 25 Sep 2001 15:31:19 -0700 (PDT)
      
[ replying to self...]

   Hmmm, net/ipv6/sit.c already has the version you propose. :-)))
   Which one is correct?
   
   Alexey, what do you think?

Nevermind, it is clear that Andrew's patch is correct.
I've applied it, thanks.

Franks a lot,
David S. Miller
davem@redhat.com