From: Vojtech Pavlik <vojtech@suse.cz>
To: Linus Torvalds <linus@transmeta.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: [patch] Fix 'get mouse type' command emulation in mousedev.c
Date: Thu, 27 Sep 2001 23:56:55 +0200 [thread overview]
Message-ID: <20010927235655.A18423@suse.cz> (raw)
Hi!
New GPM (1.19.4+) uses a more sophisticated method of detecting PS/2
mice. This uncovers a minor bug in mousedev. Mousedev reports always
mouse type 4 (ExplorerPS/2) regardless of the mode it is in due to
missing break;'s in a switch statement. This patch fixes it. Patch against
2.4.10 or similar.
--- linux-2.4.10/drivers/input/mousedev.c Thu Sep 13 00:34:06 2001
+++ linux/drivers/input/mousedev.c Thu Sep 27 23:47:59 2001
@@ -314,9 +314,9 @@
case 0xf2: /* Get ID */
switch (list->mode) {
- case 0: list->ps2[1] = 0;
- case 1: list->ps2[1] = 3;
- case 2: list->ps2[1] = 4;
+ case 0: list->ps2[1] = 0; break;
+ case 1: list->ps2[1] = 3; break;
+ case 2: list->ps2[1] = 4; break;
}
list->bufsiz = 2;
break;
--
Vojtech Pavlik
SuSE Labs
reply other threads:[~2001-09-27 21:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010927235655.A18423@suse.cz \
--to=vojtech@suse.cz \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linus@transmeta.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®