* [patch] Fix 'get mouse type' command emulation in mousedev.c
@ 2001-09-27 21:56 Vojtech Pavlik
0 siblings, 0 replies; only message in thread
From: Vojtech Pavlik @ 2001-09-27 21:56 UTC (permalink / raw)
To: Linus Torvalds, Alan Cox; +Cc: linux-kernel
Hi!
New GPM (1.19.4+) uses a more sophisticated method of detecting PS/2
mice. This uncovers a minor bug in mousedev. Mousedev reports always
mouse type 4 (ExplorerPS/2) regardless of the mode it is in due to
missing break;'s in a switch statement. This patch fixes it. Patch against
2.4.10 or similar.
--- linux-2.4.10/drivers/input/mousedev.c Thu Sep 13 00:34:06 2001
+++ linux/drivers/input/mousedev.c Thu Sep 27 23:47:59 2001
@@ -314,9 +314,9 @@
case 0xf2: /* Get ID */
switch (list->mode) {
- case 0: list->ps2[1] = 0;
- case 1: list->ps2[1] = 3;
- case 2: list->ps2[1] = 4;
+ case 0: list->ps2[1] = 0; break;
+ case 1: list->ps2[1] = 3; break;
+ case 2: list->ps2[1] = 4; break;
}
list->bufsiz = 2;
break;
--
Vojtech Pavlik
SuSE Labs
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2001-09-27 21:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-09-27 21:56 [patch] Fix 'get mouse type' command emulation in mousedev.c Vojtech Pavlik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®