mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kuznet@ms2.inr.ac.ru
To: mingo@elte.hu
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org,
	alan@lxorguk.ukuu.org.uk, bcrl@redhat.com, andrea@suse.de
Subject: Re: [patch] softirq performance fixes, cleanups, 2.4.10.
Date: Fri, 28 Sep 2001 20:18:20 +0400 (MSK DST)	[thread overview]
Message-ID: <200109281618.UAA04122@ms2.inr.ac.ru> (raw)
In-Reply-To: <Pine.LNX.4.33.0109261729570.5644-200000@localhost.localdomain> from "Ingo Molnar" at Sep 26, 1 06:44:03 pm

Hello!

>  - removed 'mask' handling from do_softirq() - it's unnecessery due to the
>    restarts. this further simplifies the code.

Ingo, but this means that only the first softirq is handled.
"mask" implements round-robin and this is necessary.


>  - '[ksoftirqd_CPU0]' is confusing on UP systems, changed it to
>    '[ksoftirqd]' instead.

It is useless to argue about preferences, but universal naming scheme
looks as less confusing yet. :-)


Generally, I dislike this patch. It is utterly ugly.

Also, you did not assure me that you interpret problem correctly.
netif_rx() is __insensitive__ to latencies due to blocked softirq restarts.
It stops spinning only when it becomes true cpu hog. And scheduling ksoftirqd
is the only variant here.

Most likely, your problem will disappear when you renice ksoftirqd
to higher priority f.e. equal to priority of tux threads.

Alexey

  parent reply	other threads:[~2001-09-28 16:18 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-26 16:44 Ingo Molnar
2001-09-26 17:48 ` Mike Kravetz
2001-09-26 18:48   ` Ingo Molnar
2001-09-26 18:55 ` Russell King
2001-09-26 19:14   ` Ingo Molnar
2001-09-27 23:31 ` Andrea Arcangeli
2001-09-28  3:20   ` Andrea Arcangeli
2001-09-28  7:34     ` Ingo Molnar
2001-09-28 15:17       ` Andrea Arcangeli
2001-09-28  7:18   ` [patch] softirq-2.4.10-B2 Ingo Molnar
2001-09-28 15:58     ` Andrea Arcangeli
2001-09-28 18:36     ` Simon Kirby
2001-09-28 18:47       ` Ingo Molnar
2001-09-28 19:31         ` kuznet
2001-09-28 16:18 ` kuznet [this message]
2001-09-28 16:31   ` [patch] softirq performance fixes, cleanups, 2.4.10 Ingo Molnar
2001-09-28 17:04     ` kuznet
2001-09-28 17:21       ` Rik van Riel
2001-09-28 17:31         ` Andrea Arcangeli
2001-09-28 17:41         ` kuznet
2001-09-28 17:46           ` Ingo Molnar
2001-09-28 18:39         ` Josh MacDonald
2001-09-28 17:31       ` Ingo Molnar
2001-09-28 17:56         ` kuznet
2001-09-28 18:28           ` Ingo Molnar
2001-09-28 19:23             ` kuznet
2001-09-28 19:48               ` Ingo Molnar
2001-09-29 16:35                 ` kuznet
2001-09-30  9:37                   ` Kai Henningsen
2001-09-30  9:01               ` Ingo Molnar
2001-09-28 19:39             ` kuznet
2001-09-28 20:03               ` Ingo Molnar
2001-09-28 18:51           ` Benjamin LaHaise
2001-09-28 16:32   ` Andrea Arcangeli
2001-09-28 16:46     ` Ingo Molnar
2001-09-28 16:58       ` Andrea Arcangeli
2001-09-28 16:35   ` [patch] softirq-2.4.10-B3 Ingo Molnar
2001-09-29  0:40     ` J . A . Magallon
2001-09-29 11:03 ` [patch] softirq performance fixes, cleanups, 2.4.10 Rusty Russell
2001-09-27 23:29 Oleg Nesterov
2001-09-28  0:03 ` Andrea Arcangeli
2001-09-28  6:57 ` Ingo Molnar
2001-09-28  2:50 Oleg Nesterov
2001-09-28  7:56 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200109281618.UAA04122@ms2.inr.ac.ru \
    --to=kuznet@ms2.inr.ac.ru \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=andrea@suse.de \
    --cc=bcrl@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®