From: jdthood@home.dhs.org (Thomas Hood)
To: linux-kernel@vger.kernel.org
Subject: call_pnp_bios() okay
Date: Wed, 3 Oct 2001 12:15:28 -0400 (EDT) [thread overview]
Message-ID: <20011003161528.757EA5AC@thanatos.toad.net> (raw)
> Given that the args are u16s and u16s are unsigned shorts, it looks to me
> as if this is going to zero out all the odd-numbered args. But if that's
> what's happening then I'm amazed this driver works at all. I see that
> in some cases the odd-numbered args are zero anyway, but in others not.
> Result #1: The driver isn't getting a real value for the maximum node size.
> But a random value will sometimes not oops the kernel.
> Result #2: PnP BIOS is sometimes getting 0 as its DS selector
> Result #3: The get_dev_node config selector is always 0 (should be 1 or 2)
> Result #4: The set_dev_node handle is 0; but this is duplicated in the
> node info structure, so the function may still work. However,
> the selector number of the node data is wrong
>
> I'm off to patch this bug and see if it fixes my problem.
> It may fix the Sony and Dell problems too.
Well, on closer look the call_pnp_bios code is okay after all.
The variables get promoted to 32 bits prior to the 16 bit shifts,
despite the shifts being in parentheses. I.e, Never Mind. :)
Stelian: Sorry, I put your e-mail address in the previous subject heading
by mistake.
--
Thomas Hood
(Don't reply to the From: address but to jdthood_AT_yahoo.co.uk)
reply other threads:[~2001-10-03 16:16 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011003161528.757EA5AC@thanatos.toad.net \
--to=jdthood@home.dhs.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®