mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* call_pnp_bios() okay
@ 2001-10-03 16:15 Thomas Hood
  0 siblings, 0 replies; only message in thread
From: Thomas Hood @ 2001-10-03 16:15 UTC (permalink / raw)
  To: linux-kernel

> Given that the args are u16s and u16s are unsigned shorts, it looks to me
> as if this is going to zero out all the odd-numbered args.  But if that's
> what's happening then I'm amazed this driver works at all.  I see that
> in some cases the odd-numbered args are zero anyway, but in others not.
> Result #1:  The driver isn't getting a real value for the maximum node size.
>             But a random value will sometimes not oops the kernel.
> Result #2:  PnP BIOS is sometimes getting 0 as its DS selector
> Result #3:  The get_dev_node config selector is always 0 (should be 1 or 2)
> Result #4:  The set_dev_node handle is 0; but this is duplicated in the
>             node info structure, so the function may still work.  However,
>             the selector number of the node data is wrong
> 
> I'm off to patch this bug and see if it fixes my problem.
> It may fix the Sony and Dell problems too.

Well, on closer look the call_pnp_bios code is okay after all.
The variables get promoted to 32 bits prior to the 16 bit shifts,
despite the shifts being in parentheses.  I.e, Never Mind.  :)

Stelian: Sorry, I put your e-mail address in the previous subject heading
by mistake.

-- 
Thomas Hood
(Don't reply to the From: address but to jdthood_AT_yahoo.co.uk)

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2001-10-03 16:16 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-10-03 16:15 call_pnp_bios() okay Thomas Hood

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®