Re: ENOATTR and other error enums

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* Re: ENOATTR and other error enums
       [not found] <200110060624.f966OeV30354@monkeyiq.dnsalias.org>
@ 2001-10-08  1:22 ` Nathan Scott
  2001-10-09  5:01   ` [PATCH] " Nathan Scott
  0 siblings, 1 reply; 4+ messages in thread
From: Nathan Scott @ 2001-10-08  1:22 UTC (permalink / raw)
  To: monkeyiq; +Cc: Andreas Gruenbacher, linux-xfs, linux-kernel

hi there,

On Sat, Oct 06, 2001 at 04:24:40PM +1000, monkeyiq wrote:
> Hi,
>   Anyone know where these are defined in Linux? I dont seem
> to be able to find them, even with find/grep in /usr/include.

ENOATTR is not a blessed errno in Linux.  In XFS we have simply
defined it to be the same as ENODATA for the time being.  The
ext2 extended attributes project define it to be EDOM, also as
a stop-gap solution I imagine.

A similar problem exists with ENOTSUP (defined by POSIX 1003.1b?)
- this is only supported via linux/asm-parisc/errno.h as a real
errno, among all the architectures.  Both the XFS and ext2 extended
attributes implementations define this errno to be EOPNOTSUPP as an
interim solution.  Ah, wait - from a quick test, glibc does seem to
do exactly this also, so this one is not a problem (except perhaps
on the parisc port? -- hmm, that could actually be a bug on parisc).

On a related topic, but not specific to extended attributes - for
XFS in general, we needed one other errno - EFSCORRUPTED.  This is
used when XFS goes into forced shutdown mode for a filesystem that
has been detected as on-disk corrupt, to stop making the situation
any worse (user must umount/xfs_repair).  We couldn't find any pre-
existing Linux errno vaguely similar to this one, so it was defined
to "990" until a real solution could be found.

Obviously, these are not the correct long-term solutions ... they
need to become real Linux errno's, I think, and ENOTSUP could be
defined to EOPNOTSUPP? - EWOULDBLOCK, EDEADLOCK seem to do this.
I'm not sure how to reach that point though (CC'ing linux-kernel
for any advice) - for reference, in IRIX these errnos are defined
as follows:

ENOATTR = Attribute not found
EFSCORRUPTED = Filesystem is corrupted

> Also, is there a function to get a string rep of the error
> that occured in the attr code?

Someday it should become a part of asm-XXXXX/errno.h (errno's are
architecture specific) and the libc strerror(3) routine should be
able to provide a meaningful string.  But currently that does not
happen.

cheers.

-- 
Nathan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] Re: ENOATTR and other error enums
  2001-10-08  1:22 ` ENOATTR and other error enums Nathan Scott
@ 2001-10-09  5:01   ` Nathan Scott
  2001-10-09 12:37     ` Alan Cox
  0 siblings, 1 reply; 4+ messages in thread
From: Nathan Scott @ 2001-10-09  5:01 UTC (permalink / raw)
  To: Linus Torvalds, Alan Cox; +Cc: Andreas Gruenbacher, linux-xfs, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 2789 bytes --]

hi fellas,

Here is an errno.h patch which provides these new errno values.
XFS needs both values.  ENOATTR is also required by the ext2
extended attributes project (and any other filesystem intending
to implement extended attributes in the future).  Both values
need to be visible in both kernel and user space, so this patch
would be an initial step toward libc support also, hopefully.

In the absence of any cleaner way to do this (?), could we have
this patch applied please?  Any/all feedback much appreciated
-- thanks.

cheers.


On Mon, Oct 08, 2001 at 12:22:02PM +1100, Nathan Scott wrote:
> hi there,
> 
> On Sat, Oct 06, 2001 at 04:24:40PM +1000, monkeyiq wrote:
> > Hi,
> >   Anyone know where these are defined in Linux? I dont seem
> > to be able to find them, even with find/grep in /usr/include.
> 
> ENOATTR is not a blessed errno in Linux.  In XFS we have simply
> defined it to be the same as ENODATA for the time being.  The
> ext2 extended attributes project define it to be EDOM, also as
> a stop-gap solution I imagine.
> 
> A similar problem exists with ENOTSUP (defined by POSIX 1003.1b?)
> - this is only supported via linux/asm-parisc/errno.h as a real
> errno, among all the architectures.  Both the XFS and ext2 extended
> attributes implementations define this errno to be EOPNOTSUPP as an
> interim solution.  Ah, wait - from a quick test, glibc does seem to
> do exactly this also, so this one is not a problem (except perhaps
> on the parisc port? -- hmm, that could actually be a bug on parisc).
> 
> On a related topic, but not specific to extended attributes - for
> XFS in general, we needed one other errno - EFSCORRUPTED.  This is
> used when XFS goes into forced shutdown mode for a filesystem that
> has been detected as on-disk corrupt, to stop making the situation
> any worse (user must umount/xfs_repair).  We couldn't find any pre-
> existing Linux errno vaguely similar to this one, so it was defined
> to "990" until a real solution could be found.
> 
> Obviously, these are not the correct long-term solutions ... they
> need to become real Linux errno's, I think, and ENOTSUP could be
> defined to EOPNOTSUPP? - EWOULDBLOCK, EDEADLOCK seem to do this.
> I'm not sure how to reach that point though (CC'ing linux-kernel
> for any advice) - for reference, in IRIX these errnos are defined
> as follows:
> 
> ENOATTR = Attribute not found
> EFSCORRUPTED = Filesystem is corrupted
> 
> > Also, is there a function to get a string rep of the error
> > that occured in the attr code?
> 
> Someday it should become a part of asm-XXXXX/errno.h (errno's are
> architecture specific) and the libc strerror(3) routine should be
> able to provide a meaningful string.  But currently that does not
> happen.
> 
> cheers.
> 
> -- 
> Nathan

-- 
Nathan

[-- Attachment #2: errno.patch --]
[-- Type: text/plain, Size: 7125 bytes --]

diff -Naur linux-vanilla/include/asm-alpha/errno.h linux-errno/include/asm-alpha/errno.h
--- linux-vanilla/include/asm-alpha/errno.h	Sat Feb 10 06:40:02 2001
+++ linux-errno/include/asm-alpha/errno.h	Tue Oct  9 11:15:13 2001
@@ -138,5 +138,7 @@
 
 #define ENOMEDIUM	129	/* No medium found */
 #define EMEDIUMTYPE	130	/* Wrong medium type */
+#define EFSCORRUPTED	131	/* Filesystem is corrupted */
+#define ENOATTR		132	/* No such attribute */
 
 #endif
diff -Naur linux-vanilla/include/asm-arm/errno.h linux-errno/include/asm-arm/errno.h
--- linux-vanilla/include/asm-arm/errno.h	Wed Jan 21 11:39:42 1998
+++ linux-errno/include/asm-arm/errno.h	Tue Oct  9 11:22:29 2001
@@ -128,5 +128,7 @@
 
 #define	ENOMEDIUM	123	/* No medium found */
 #define	EMEDIUMTYPE	124	/* Wrong medium type */
+#define	EFSCORRUPTED	125	/* Filesystem is corrupted */
+#define	ENOATTR		126	/* No such attribute */
 
 #endif
diff -Naur linux-vanilla/include/asm-cris/errno.h linux-errno/include/asm-cris/errno.h
--- linux-vanilla/include/asm-cris/errno.h	Fri Feb  9 11:32:44 2001
+++ linux-errno/include/asm-cris/errno.h	Tue Oct  9 11:22:41 2001
@@ -130,5 +130,7 @@
 
 #define	ENOMEDIUM	123	/* No medium found */
 #define	EMEDIUMTYPE	124	/* Wrong medium type */
+#define	EFSCORRUPTED	125	/* Filesystem is corrupted */
+#define	ENOATTR		126	/* No such attribute */
 
 #endif
diff -Naur linux-vanilla/include/asm-i386/errno.h linux-errno/include/asm-i386/errno.h
--- linux-vanilla/include/asm-i386/errno.h	Sat Feb 10 06:40:02 2001
+++ linux-errno/include/asm-i386/errno.h	Tue Oct  9 11:23:02 2001
@@ -128,5 +128,7 @@
 
 #define	ENOMEDIUM	123	/* No medium found */
 #define	EMEDIUMTYPE	124	/* Wrong medium type */
+#define	EFSCORRUPTED	125	/* Filesystem is corrupted */
+#define	ENOATTR		126	/* No such attribute */
 
 #endif
diff -Naur linux-vanilla/include/asm-ia64/errno.h linux-errno/include/asm-ia64/errno.h
--- linux-vanilla/include/asm-ia64/errno.h	Wed Apr 11 05:23:06 2001
+++ linux-errno/include/asm-ia64/errno.h	Tue Oct  9 11:23:12 2001
@@ -135,5 +135,7 @@
 
 #define	ENOMEDIUM	123	/* No medium found */
 #define	EMEDIUMTYPE	124	/* Wrong medium type */
+#define	EFSCORRUPTED	125	/* Filesystem is corrupted */
+#define	ENOATTR		126	/* No such attribute */
 
 #endif /* _ASM_IA64_ERRNO_H */
diff -Naur linux-vanilla/include/asm-m68k/errno.h linux-errno/include/asm-m68k/errno.h
--- linux-vanilla/include/asm-m68k/errno.h	Sat Feb 10 06:40:02 2001
+++ linux-errno/include/asm-m68k/errno.h	Tue Oct  9 11:23:24 2001
@@ -128,5 +128,7 @@
 
 #define	ENOMEDIUM	123	/* No medium found */
 #define	EMEDIUMTYPE	124	/* Wrong medium type */
+#define	EFSCORRUPTED	125	/* Filesystem is corrupted */
+#define	ENOATTR		126	/* No such attribute */
 
 #endif /* _M68K_ERRNO_H */
diff -Naur linux-vanilla/include/asm-mips/errno.h linux-errno/include/asm-mips/errno.h
--- linux-vanilla/include/asm-mips/errno.h	Tue Jul  3 06:56:40 2001
+++ linux-errno/include/asm-mips/errno.h	Tue Oct  9 11:14:37 2001
@@ -141,6 +141,8 @@
  */
 #define ENOMEDIUM	159	/* No medium found */
 #define EMEDIUMTYPE	160	/* Wrong medium type */
+#define EFSCORRUPTED	161	/* Filesystem is corrupted */
+#define ENOATTR		162	/* No such attribute */
 
 #define EDQUOT		1133	/* Quota exceeded */
 
diff -Naur linux-vanilla/include/asm-mips64/errno.h linux-errno/include/asm-mips64/errno.h
--- linux-vanilla/include/asm-mips64/errno.h	Sat Apr 14 13:26:07 2001
+++ linux-errno/include/asm-mips64/errno.h	Tue Oct  9 11:17:07 2001
@@ -142,6 +142,8 @@
  */
 #define ENOMEDIUM	159	/* No medium found */
 #define EMEDIUMTYPE	160	/* Wrong medium type */
+#define EFSCORRUPTED	161	/* Filesystem is corrupted */
+#define ENOATTR		162	/* No such attribute */
 
 #define EDQUOT		1133	/* Quota exceeded */
 
diff -Naur linux-vanilla/include/asm-parisc/errno.h linux-errno/include/asm-parisc/errno.h
--- linux-vanilla/include/asm-parisc/errno.h	Wed Dec  6 07:29:39 2000
+++ linux-errno/include/asm-parisc/errno.h	Tue Oct  9 11:23:43 2001
@@ -99,6 +99,8 @@
 #define	EREMOTEIO	181	/* Remote I/O error */
 #define	ENOMEDIUM	182	/* No medium found */
 #define	EMEDIUMTYPE	183	/* Wrong medium type */
+#define	EFSCORRUPTED	184	/* Filesystem is corrupted */
+#define	ENOATTR		185	/* No such attribute */
 
 /* We now return you to your regularly scheduled HPUX. */
 
diff -Naur linux-vanilla/include/asm-ppc/errno.h linux-errno/include/asm-ppc/errno.h
--- linux-vanilla/include/asm-ppc/errno.h	Tue May 22 08:02:06 2001
+++ linux-errno/include/asm-ppc/errno.h	Tue Oct  9 11:23:55 2001
@@ -129,6 +129,8 @@
 
 #define	ENOMEDIUM	123	/* No medium found */
 #define	EMEDIUMTYPE	124	/* Wrong medium type */
+#define	EFSCORRUPTED	125	/* Filesystem is corrupted */
+#define	ENOATTR		126	/* No such attribute */
 
 /* Should never be seen by user programs */
 #define ERESTARTSYS	512
diff -Naur linux-vanilla/include/asm-s390/errno.h linux-errno/include/asm-s390/errno.h
--- linux-vanilla/include/asm-s390/errno.h	Sat May 13 04:41:44 2000
+++ linux-errno/include/asm-s390/errno.h	Tue Oct  9 11:24:08 2001
@@ -136,5 +136,7 @@
 
 #define	ENOMEDIUM	123	/* No medium found */
 #define	EMEDIUMTYPE	124	/* Wrong medium type */
+#define	EFSCORRUPTED	125	/* Filesystem is corrupted */
+#define	ENOATTR		126	/* No such attribute */
 
 #endif
diff -Naur linux-vanilla/include/asm-s390x/errno.h linux-errno/include/asm-s390x/errno.h
--- linux-vanilla/include/asm-s390x/errno.h	Wed Feb 14 09:13:44 2001
+++ linux-errno/include/asm-s390x/errno.h	Tue Oct  9 11:24:16 2001
@@ -136,5 +136,7 @@
 
 #define	ENOMEDIUM	123	/* No medium found */
 #define	EMEDIUMTYPE	124	/* Wrong medium type */
+#define	EFSCORRUPTED	125	/* Filesystem is corrupted */
+#define	ENOATTR		126	/* No such attribute */
 
 #endif
diff -Naur linux-vanilla/include/asm-sh/errno.h linux-errno/include/asm-sh/errno.h
--- linux-vanilla/include/asm-sh/errno.h	Tue Aug 31 11:12:59 1999
+++ linux-errno/include/asm-sh/errno.h	Tue Oct  9 11:24:25 2001
@@ -128,5 +128,7 @@
 
 #define	ENOMEDIUM	123	/* No medium found */
 #define	EMEDIUMTYPE	124	/* Wrong medium type */
+#define	EFSCORRUPTED	125	/* Filesystem is corrupted */
+#define	ENOATTR		126	/* No such attribute */
 
 #endif /* __ASM_SH_ERRNO_H */
diff -Naur linux-vanilla/include/asm-sparc/errno.h linux-errno/include/asm-sparc/errno.h
--- linux-vanilla/include/asm-sparc/errno.h	Thu Apr 24 12:01:28 1997
+++ linux-errno/include/asm-sparc/errno.h	Tue Oct  9 11:24:35 2001
@@ -132,5 +132,7 @@
 
 #define	ENOMEDIUM	125	/* No medium found */
 #define	EMEDIUMTYPE	126	/* Wrong medium type */
+#define	EFSCORRUPTED	127	/* Filesystem is corrupted */
+#define	ENOATTR		128	/* No such attribute */
 
 #endif
diff -Naur linux-vanilla/include/asm-sparc64/errno.h linux-errno/include/asm-sparc64/errno.h
--- linux-vanilla/include/asm-sparc64/errno.h	Thu Apr 24 12:01:28 1997
+++ linux-errno/include/asm-sparc64/errno.h	Tue Oct  9 11:28:03 2001
@@ -132,5 +132,7 @@
 
 #define ENOMEDIUM       125     /* No medium found */
 #define EMEDIUMTYPE     126     /* Wrong medium type */
+#define EFSCORRUPTED    127     /* Filesystem is corrupted */
+#define ENOATTR         128     /* No such attribute */
 
 #endif /* !(_SPARC64_ERRNO_H) */

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Re: ENOATTR and other error enums
  2001-10-09  5:01   ` [PATCH] " Nathan Scott
@ 2001-10-09 12:37     ` Alan Cox
  2001-10-09 13:31       ` Nathan Scott
  0 siblings, 1 reply; 4+ messages in thread
From: Alan Cox @ 2001-10-09 12:37 UTC (permalink / raw)
  To: Nathan Scott
  Cc: Linus Torvalds, Alan Cox, Andreas Gruenbacher, linux-xfs, linux-kernel

> XFS needs both values.  ENOATTR is also required by the ext2
> extended attributes project (and any other filesystem intending
> to implement extended attributes in the future).  Both values
> need to be visible in both kernel and user space, so this patch
> would be an initial step toward libc support also, hopefully.
> 
> In the absence of any cleaner way to do this (?), could we have
> this patch applied please?  Any/all feedback much appreciated

Such an update needs to be synchronized with glibc to avoid people
getting all sorts of odd "unknown" error messages. In general I dn't
see why its needed.

> > EFSCORRUPTED = Filesystem is corrupted

EIO is normally used for this

As to the string names for errors. They can't sanely go into the kernel
or kernel headers. Remember there are a lot of languages out there

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Re: ENOATTR and other error enums
  2001-10-09 12:37     ` Alan Cox
@ 2001-10-09 13:31       ` Nathan Scott
  0 siblings, 0 replies; 4+ messages in thread
From: Nathan Scott @ 2001-10-09 13:31 UTC (permalink / raw)
  To: Alan Cox; +Cc: Linus Torvalds, Andreas Gruenbacher, linux-xfs, linux-kernel

hi Alan,

Thanks for the comments.

On Tue, Oct 09, 2001 at 01:37:55PM +0100, Alan Cox wrote:
> > XFS needs both values.  ENOATTR is also required by the ext2
> > extended attributes project (and any other filesystem intending
> > to implement extended attributes in the future).  Both values
> > need to be visible in both kernel and user space, so this patch
> > would be an initial step toward libc support also, hopefully.
> > 
> > In the absence of any cleaner way to do this (?), could we have
> > this patch applied please?  Any/all feedback much appreciated
> 
> Such an update needs to be synchronized with glibc to avoid people
> getting all sorts of odd "unknown" error messages.

Yup, understood.  I was punting that it would need to appear
in the kernel headers first though, so thought I'd test the
water with you guys and try to understand the process for such
a change.

The "unknown error" messages can't really be avoided in all cases
anyway - even when there is a coordinated libc release there will
always be (the vast majority of?) people running new kernels with
older libc versions for awhile ... thats life though, I guess, if
there's no other solution to the problem.

> In general I dn't see why its needed.

For ENOATTR, an error code is needed which doesn't conflict
with any other used in the filesystem, so that a failure to
get/set/... an extended attribute can be distinguished from
other errors related to looking up the pathname initially,
as an example.

> > > EFSCORRUPTED = Filesystem is corrupted
> 
> EIO is normally used for this

Yeah, the semantics here are slightly different, but perhaps we
can get away with this... (Steve?  do you know of any cases in
the code where we need to be able to distinguish the EIO value
from EFSCORRUPTED?  or any other reason why this wouldn't work?
It is the obvious one - I'd imagine there was a reason for not
using it originally).

> As to the string names for errors. They can't sanely go into the kernel
> or kernel headers.

Yes, that wasn't being suggested.

> Remember there are a lot of languages out there

Yup - understood.

thanks.

-- 
Nathan

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2001-10-09 13:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <200110060624.f966OeV30354@monkeyiq.dnsalias.org>
2001-10-08  1:22 ` ENOATTR and other error enums Nathan Scott
2001-10-09  5:01   ` [PATCH] " Nathan Scott
2001-10-09 12:37     ` Alan Cox
2001-10-09 13:31       ` Nathan Scott

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®