Re: [PATCH] USB Support for recent Casio Digital Still Cameras, linux-2.4.11

[Matthew Dharm <mdharm-kernel@one-eyed-alien.net>]

[-- Attachment #1: Type: text/plain, Size: 2268 bytes --]

In my experience, if you've tested the endpoints on these things, you've
covered the middle.  I'd rather have the single entry.

Matt

On Thu, Oct 11, 2001 at 02:36:47AM +0200, Jan Niehusmann wrote:
> On Thu, Oct 11, 2001 at 02:11:56AM +0200, Harald Schreiber wrote:
> > Recent Casio QV digital still cameras (for example the QV 4000)
> > show up as 
> > VendorID: 0x07cf  ProductID: 0x1001  Revision: 10.00
> > 
> > So the following patch is necessary to make these devices working
> > with the USB storage driver. The patch is against linux-2.4.11,
> > but it should work with any kernel since 2.4.8-pre3.
> 
> Confirmed. I sent the same patch (without the comments) to linux-kernel
> three days ago.
> 
> BTW, perhaps it would be better to patch the thing the following way,
> because I don't know what's in the revision number range between
> 1000 and 9009, perhaps there are other devices which don't like the
> workaround?
> 
> 
> --- linux-2.4.9-ac10/drivers/usb/storage/unusual_devs.h	Sat Sep  8 18:18:51 2001
> +++ linux-2.4.10-ac11/drivers/usb/storage/unusual_devs.h	Thu Oct 11 02:11:29 2001
> @@ -394,6 +394,12 @@
>   * - They don't like the INQUIRY command. So we must handle this command
>   *   of the SCSI layer ourselves.
>   */
> +UNUSUAL_DEV( 0x07cf, 0x1001, 0x1000, 0x1000,
> +                "Casio",
> +                "QV DigitalCamera",
> +                US_SC_8070, US_PR_CB, NULL,
> +                US_FL_FIX_INQUIRY ),
> +
>  UNUSUAL_DEV( 0x07cf, 0x1001, 0x9009, 0x9009,
>                  "Casio",
>                  "QV DigitalCamera",
> 
> > --------------------------------------------------------------------
> > Dipl.-Math. Harald Schreiber, Nizzaallee 26, D-52072 Aachen, Germany
> > Phone/Fax: +49-241-9108015/6       mailto:harald@harald-schreiber.de
> > --------------------------------------------------------------------
> 
> Interesting, twice the same patch, and then from nearly the same location
> in the world. (Roermonder Str. 112a - distance several 100m )
> 
> Jan

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

God, root, what is difference?
					-- Pitr
User Friendly, 11/11/1999

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]