mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] USB Support for recent Casio Digital Still Cameras, linux-2.4.11
@ 2001-10-11  0:11 Harald Schreiber
  2001-10-11  0:36 ` Jan Niehusmann
  0 siblings, 1 reply; 3+ messages in thread
From: Harald Schreiber @ 2001-10-11  0:11 UTC (permalink / raw)
  To: mdharm-usb, linux-kernel, linux-usb-devel


Recent Casio QV digital still cameras (for example the QV 4000)
show up as 
VendorID: 0x07cf  ProductID: 0x1001  Revision: 10.00

So the following patch is necessary to make these devices working
with the USB storage driver. The patch is against linux-2.4.11,
but it should work with any kernel since 2.4.8-pre3.



diff -Naur linux-2.4.11/drivers/usb/storage/unusual_devs.h linux/drivers/usb/storage/unusual_devs.h
--- linux-2.4.11/drivers/usb/storage/unusual_devs.h	Tue Sep 25 16:35:39 2001
+++ linux/drivers/usb/storage/unusual_devs.h	Thu Oct 11 00:28:22 2001
@@ -376,14 +376,15 @@
 		US_FL_MODE_XLATE | US_FL_START_STOP ),
 #endif
 
-/* Casio QV 2x00/3x00/8000 digital still cameras are not conformant
- * to the USB storage specification in two ways:
+/* Casio QV 3 / QV 2x00 / QV 3x00 / QV 4000 / QV 8000 digital still cameras
+ * are not conformant  to the USB storage specification in two ways:
  * - They tell us they are using transport protocol CBI. In reality they
  *   are using transport protocol CB.
  * - They don't like the INQUIRY command. So we must handle this command
  *   of the SCSI layer ourselves.
+ * Submitted by Harald Schreiber <harald@harald-schreiber.de>.
  */
-UNUSUAL_DEV( 0x07cf, 0x1001, 0x9009, 0x9009,
+UNUSUAL_DEV( 0x07cf, 0x1001, 0x1000, 0x9009,
                 "Casio",
                 "QV DigitalCamera",
                 US_SC_8070, US_PR_CB, NULL,


-- 
--------------------------------------------------------------------
Dipl.-Math. Harald Schreiber, Nizzaallee 26, D-52072 Aachen, Germany
Phone/Fax: +49-241-9108015/6       mailto:harald@harald-schreiber.de
--------------------------------------------------------------------

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] USB Support for recent Casio Digital Still Cameras, linux-2.4.11
  2001-10-11  0:11 [PATCH] USB Support for recent Casio Digital Still Cameras, linux-2.4.11 Harald Schreiber
@ 2001-10-11  0:36 ` Jan Niehusmann
  2001-10-11  0:41   ` Matthew Dharm
  0 siblings, 1 reply; 3+ messages in thread
From: Jan Niehusmann @ 2001-10-11  0:36 UTC (permalink / raw)
  To: Harald Schreiber; +Cc: mdharm-usb, linux-kernel, linux-usb-devel

On Thu, Oct 11, 2001 at 02:11:56AM +0200, Harald Schreiber wrote:
> Recent Casio QV digital still cameras (for example the QV 4000)
> show up as 
> VendorID: 0x07cf  ProductID: 0x1001  Revision: 10.00
> 
> So the following patch is necessary to make these devices working
> with the USB storage driver. The patch is against linux-2.4.11,
> but it should work with any kernel since 2.4.8-pre3.

Confirmed. I sent the same patch (without the comments) to linux-kernel
three days ago.

BTW, perhaps it would be better to patch the thing the following way,
because I don't know what's in the revision number range between
1000 and 9009, perhaps there are other devices which don't like the
workaround?


--- linux-2.4.9-ac10/drivers/usb/storage/unusual_devs.h	Sat Sep  8 18:18:51 2001
+++ linux-2.4.10-ac11/drivers/usb/storage/unusual_devs.h	Thu Oct 11 02:11:29 2001
@@ -394,6 +394,12 @@
  * - They don't like the INQUIRY command. So we must handle this command
  *   of the SCSI layer ourselves.
  */
+UNUSUAL_DEV( 0x07cf, 0x1001, 0x1000, 0x1000,
+                "Casio",
+                "QV DigitalCamera",
+                US_SC_8070, US_PR_CB, NULL,
+                US_FL_FIX_INQUIRY ),
+
 UNUSUAL_DEV( 0x07cf, 0x1001, 0x9009, 0x9009,
                 "Casio",
                 "QV DigitalCamera",

> --------------------------------------------------------------------
> Dipl.-Math. Harald Schreiber, Nizzaallee 26, D-52072 Aachen, Germany
> Phone/Fax: +49-241-9108015/6       mailto:harald@harald-schreiber.de
> --------------------------------------------------------------------

Interesting, twice the same patch, and then from nearly the same location
in the world. (Roermonder Str. 112a - distance several 100m )

Jan


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] USB Support for recent Casio Digital Still Cameras, linux-2.4.11
  2001-10-11  0:36 ` Jan Niehusmann
@ 2001-10-11  0:41   ` Matthew Dharm
  0 siblings, 0 replies; 3+ messages in thread
From: Matthew Dharm @ 2001-10-11  0:41 UTC (permalink / raw)
  To: Jan Niehusmann; +Cc: Harald Schreiber, linux-kernel, linux-usb-devel

[-- Attachment #1: Type: text/plain, Size: 2268 bytes --]

In my experience, if you've tested the endpoints on these things, you've
covered the middle.  I'd rather have the single entry.

Matt

On Thu, Oct 11, 2001 at 02:36:47AM +0200, Jan Niehusmann wrote:
> On Thu, Oct 11, 2001 at 02:11:56AM +0200, Harald Schreiber wrote:
> > Recent Casio QV digital still cameras (for example the QV 4000)
> > show up as 
> > VendorID: 0x07cf  ProductID: 0x1001  Revision: 10.00
> > 
> > So the following patch is necessary to make these devices working
> > with the USB storage driver. The patch is against linux-2.4.11,
> > but it should work with any kernel since 2.4.8-pre3.
> 
> Confirmed. I sent the same patch (without the comments) to linux-kernel
> three days ago.
> 
> BTW, perhaps it would be better to patch the thing the following way,
> because I don't know what's in the revision number range between
> 1000 and 9009, perhaps there are other devices which don't like the
> workaround?
> 
> 
> --- linux-2.4.9-ac10/drivers/usb/storage/unusual_devs.h	Sat Sep  8 18:18:51 2001
> +++ linux-2.4.10-ac11/drivers/usb/storage/unusual_devs.h	Thu Oct 11 02:11:29 2001
> @@ -394,6 +394,12 @@
>   * - They don't like the INQUIRY command. So we must handle this command
>   *   of the SCSI layer ourselves.
>   */
> +UNUSUAL_DEV( 0x07cf, 0x1001, 0x1000, 0x1000,
> +                "Casio",
> +                "QV DigitalCamera",
> +                US_SC_8070, US_PR_CB, NULL,
> +                US_FL_FIX_INQUIRY ),
> +
>  UNUSUAL_DEV( 0x07cf, 0x1001, 0x9009, 0x9009,
>                  "Casio",
>                  "QV DigitalCamera",
> 
> > --------------------------------------------------------------------
> > Dipl.-Math. Harald Schreiber, Nizzaallee 26, D-52072 Aachen, Germany
> > Phone/Fax: +49-241-9108015/6       mailto:harald@harald-schreiber.de
> > --------------------------------------------------------------------
> 
> Interesting, twice the same patch, and then from nearly the same location
> in the world. (Roermonder Str. 112a - distance several 100m )
> 
> Jan

-- 
Matthew Dharm                              Home: mdharm-usb@one-eyed-alien.net 
Maintainer, Linux USB Mass Storage Driver

God, root, what is difference?
					-- Pitr
User Friendly, 11/11/1999

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2001-10-11  0:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2001-10-11  0:11 [PATCH] USB Support for recent Casio Digital Still Cameras, linux-2.4.11 Harald Schreiber
2001-10-11  0:36 ` Jan Niehusmann
2001-10-11  0:41   ` Matthew Dharm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®