From: "David S. Miller" <davem@redhat.com>
To: viro@math.psu.edu
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [CFT][PATCH] pci/proc.c cleanup
Date: Thu, 15 Nov 2001 04:55:35 -0800 (PST) [thread overview]
Message-ID: <20011115.045535.99284023.davem@redhat.com> (raw)
In-Reply-To: <Pine.GSO.4.21.0111150100500.2244-100000@weyl.math.psu.edu>
In-Reply-To: <Pine.GSO.4.21.0111150100500.2244-100000@weyl.math.psu.edu>
From: Alexander Viro <viro@math.psu.edu>
Date: Thu, 15 Nov 2001 01:01:45 -0500 (EST)
It works here and applies both to 2.4.15-pre* and 2.4.13-ac*.
Please, test - it's pretty straightforward and if there is no complaints
I'm submitting that for inclusion into the tree.
I like this patch but I would change one thing.
"start,next,stop" sound like global kernel helper functions, not PCI
SEQ specific helpers, why not name them pci_seq_start et al. instead?
That pci_devices list does need locking, particularly with the PCI hot
plug stuff in the tree now. But PCMCIA could already change the list
after boot too if I'm not mistaken.
next prev parent reply other threads:[~2001-11-15 12:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-15 6:01 Alexander Viro
2001-11-15 12:55 ` David S. Miller [this message]
2001-11-17 2:25 ` [PATCH] more procfs fixes Alexander Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011115.045535.99284023.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®