mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Davis <alex14641@yahoo.com>
To: linux-kernel@vger.kernel.org
Subject: change to fs/proc/inode.c breaks ALSA drivers
Date: Sat, 24 Nov 2001 19:24:47 -0800 (PST)	[thread overview]
Message-ID: <20011125032447.4327.qmail@web9204.mail.yahoo.com> (raw)

Hello

Somewhere between 2.4.15pre6 and 2.4.15 final,
fs/proc/inode.c was modified. The change causes all
the devices files that ALSA creates in
/proc/asound/dev to have a major and minor number of
zero. I'm sending a patch to revert the file back to
what it was in 2.4.15pre5.


--- linux-2.4.15test/fs/proc/inode.c	Sat Nov 23
20:10:11 2001
+++ linux-2.4.15/fs/proc/inode.c	Sat Nov 24 19:56:21
2001
@@ -160,12 +160,14 @@
 			inode->i_nlink = de->nlink;
 		if (de->owner)
 			__MOD_INC_USE_COUNT(de->owner);
-		if (de->proc_iops)
-			inode->i_op = de->proc_iops;
-		if (de->proc_fops)
-			inode->i_fop = de->proc_fops;
-		else if
(S_ISBLK(de->mode)||S_ISCHR(de->mode)||S_ISFIFO(de->mode))
+		if
(S_ISBLK(de->mode)||S_ISCHR(de->mode)||S_ISFIFO(de->mode))
 		
init_special_inode(inode,de->mode,kdev_t_to_nr(de->rdev));
+		else {
+			if (de->proc_iops)
+				inode->i_op = de->proc_iops;
+			if (de->proc_fops)
+				inode->i_fop = de->proc_fops;
+		}
 	}
 
 out:


__________________________________________________
Do You Yahoo!?
Yahoo! GeoCities - quick and easy web site hosting, just $8.95/month.
http://geocities.yahoo.com/ps/info1

             reply	other threads:[~2001-11-25  3:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-25  3:24 Alex Davis [this message]
2001-11-25  8:53 ` Mike Maravillo
2001-11-25 16:53   ` Alex Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011125032447.4327.qmail@web9204.mail.yahoo.com \
    --to=alex14641@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®