mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alex Davis <alex14641@yahoo.com>
To: linux-kernel@vger.kernel.org
Subject: Re: change to fs/proc/inode.c breaks ALSA drivers
Date: Sun, 25 Nov 2001 08:53:49 -0800 (PST)	[thread overview]
Message-ID: <20011125165349.56392.qmail@web9208.mail.yahoo.com> (raw)
In-Reply-To: <20011125165352.A2784@maravillo.q-linux.com>

Thanks for the info Mike. But can anyone answer why
inode.c was changed in the first place??

--- Mike Maravillo <mike.maravillo@q-linux.com> wrote:
> On Sat, Nov 24, 2001 at 07:24:47PM -0800, Alex Davis
> wrote:
> > 
> > Somewhere between 2.4.15pre6 and 2.4.15 final,
> fs/proc/inode.c
> > was modified. The change causes all the devices
> files that ALSA
> > creates in /proc/asound/dev to have a major and
> minor number of
> > zero. I'm sending a patch to revert the file back
> to what it
> > was in 2.4.15pre5.
> 
> This change present on alsa-driver cvs fixed the
> problem on mine,
> at least.
> 
> diff -urN --exclude=CVS
> alsa-driver-0.5.12/kernel/info.c
> alsa-driver/kernel/info.c
> --- alsa-driver-0.5.12/kernel/info.c Wed Jun 28
> 02:02:03 2000
> +++ alsa-driver/kernel/info.c Wed Nov 21 23:28:35
> 2001
> @@ -897,7 +897,9 @@
>   if (p) {
>    snd_info_device_entry_prepare(p, entry);
>  #ifdef LINUX_2_3
> -  p->proc_fops = &snd_fops;
> +  /* we should not set this - at least * on 2.4.14
> or later it causes
> +     problems! */
> +  /* p->proc_fops = &snd_fops; */
>  #else
>    p->ops = &snd_info_device_inode_operations;
>  #endif
> 
> -- 
>  .--.  Michael J. Maravillo                  
> office://+63.2.894.3592/
> ( () ) Q Linux Solutions, Inc.             
> mobile://+63.917.897.0919/
>  `--\\ A Philippine Open Source Solutions Co.  http://www.q-linux.com/

__________________________________________________
Do You Yahoo!?
Yahoo! GeoCities - quick and easy web site hosting, just $8.95/month.
http://geocities.yahoo.com/ps/info1

      reply	other threads:[~2001-11-25 16:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-25  3:24 Alex Davis
2001-11-25  8:53 ` Mike Maravillo
2001-11-25 16:53   ` Alex Davis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011125165349.56392.qmail@web9208.mail.yahoo.com \
    --to=alex14641@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®