From: Richard Gooch <rgooch@ras.ucalgary.ca>
To: Alexander Viro <viro@math.psu.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Devfs races with block devices
Date: Sat, 8 Dec 2001 22:38:04 -0700 [thread overview]
Message-ID: <200112090538.fB95c4G06607@vindaloo.ras.ucalgary.ca> (raw)
In-Reply-To: <Pine.GSO.4.21.0111060202160.27713-100000@weyl.math.psu.edu>
In-Reply-To: <200111060701.fA671hL20646@vindaloo.ras.ucalgary.ca> <Pine.GSO.4.21.0111060202160.27713-100000@weyl.math.psu.edu>
[Finally, after other things have stabilised, I'm ready to tackle this
issue]
Alexander Viro writes:
> BTW, here's one more devfs rmmod race: check_disk_changed() in
> fs/devfs/base.c. Calling ->check_media_change() with no protection
> whatsoever. If rmmod happens at that point...
How about if I do this sequence:
lock_kernel();
devfs checks;
if (bd_op->owner)
__MOD_INC_USE_COUNT(bd_op->owner);
revalidate();
if (bd_op->owner)
__MOD_DEC_USE_COUNT(bd_op->owner);
unlock_kernel();
Is there any reason why that won't work?
Regards,
Richard....
Permanent: rgooch@atnf.csiro.au
Current: rgooch@ras.ucalgary.ca
next prev parent reply other threads:[~2001-12-09 5:38 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-27 15:00 Poor floppy performance in kernel 2.4.10 Alain Knaff
2001-10-27 15:15 ` Alexander Viro
2001-10-27 17:12 ` Alain Knaff
2001-10-27 17:42 ` Alexander Viro
2001-10-27 18:00 ` Alain Knaff
2001-10-27 18:13 ` Alexander Viro
2001-10-27 18:26 ` Alexander Viro
2001-10-27 19:02 ` more devfs fun Alexander Viro
2001-10-27 19:16 ` Alexander Viro
2001-10-27 19:50 ` more devfs fun (Piled Higher and Deeper) Alexander Viro
2001-10-27 20:06 ` Alexander Viro
2001-10-27 21:09 ` Ryan Cumming
2001-10-27 21:22 ` Alexander Viro
2001-10-28 1:00 ` Rik van Riel
2001-10-28 8:45 ` Richard Gooch
2001-10-28 9:54 ` Alexander Viro
2001-10-28 12:27 ` Roman Zippel
2001-10-28 13:16 ` Alexander Viro
2001-10-28 22:31 ` Richard Gooch
2001-10-28 23:11 ` Alexander Viro
2001-10-27 21:01 ` Alexander Viro
2001-11-06 6:35 ` Richard Gooch
2001-11-06 7:10 ` Alexander Viro
2001-11-06 7:14 ` Richard Gooch
2001-11-06 7:17 ` Alexander Viro
2001-11-06 20:14 ` Richard Gooch
2001-10-28 10:06 ` Lorenzo Allegrucci
2001-11-06 5:21 ` Richard Gooch
2001-11-06 5:17 ` more devfs fun Richard Gooch
2001-11-06 5:06 ` Richard Gooch
2001-11-06 7:01 ` Poor floppy performance in kernel 2.4.10 Richard Gooch
2001-11-06 7:03 ` Alexander Viro
2001-12-09 5:38 ` Richard Gooch [this message]
2001-11-06 7:19 ` Richard Gooch
2001-11-06 7:22 ` Alexander Viro
2001-10-27 19:13 ` Alain Knaff
2001-10-27 19:19 ` Alexander Viro
2001-10-27 19:26 ` Alain Knaff
2001-10-28 20:40 ` Alain Knaff
2001-10-28 20:57 ` Peter T. Breuer
2001-10-29 5:38 ` Alain Knaff
2001-10-29 6:07 ` Alexander Viro
2001-10-29 6:34 ` Alain Knaff
2001-10-28 21:42 ` Alexander Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200112090538.fB95c4G06607@vindaloo.ras.ucalgary.ca \
--to=rgooch@ras.ucalgary.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®