From: Samium Gromoff <_deepfire@mail.ru>
To: alan@lxorguk.ukuu.org.uk
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.12-ac4 10Mbit NE2k interrupt load kills p166
Date: Mon, 10 Dec 2001 02:04:22 +0300 (MSK) [thread overview]
Message-ID: <200112092304.fB9N4N008315@vegae.deep.net> (raw)
> What might be interesting would be to edit 8390.c and change
>
> /* Mask interrupts from the ethercard.
> SMP: We have to grab the lock here otherwise the IRQ handler
> on another CPU can flip window and race the IRQ mask set. We end
> up trashing the mcast filter not disabling irqs if we dont lock
> */
>
> spin_lock_irqsave(&ei_local->page_lock, flags);
> outb_p(0x00, e8390_base + EN0_IMR);
> spin_unlock_irqrestore(&ei_local->page_lock, flags);
>
> to use
>
> /* this is the missing spin_trylock_irqsave longhand.. */
> save_flags(flags);
> __cli();
> if(!spin_trylock(&ei_local->page_lock))
> {
> restore_flags(flags);
> return 1;
> }
> outb_p(0x00, e8390_base + EN0_IMR);
> spin_unlock_irqrestore(&ei_local->page_lock, flags);
building the kernel is in the progress, so i`ll report asap...
I`m so glad somebody still cares of the good ol` boxes :-)
regards, Samium Gromoff
next reply other threads:[~2001-12-09 23:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-12-09 23:04 Samium Gromoff [this message]
[not found] <Pine.LNX.4.33.0112091619190.6428-100000@coffee.psychology.mcmaster.ca>
2001-12-09 21:50 ` Samium Gromoff
2001-12-09 22:18 ` Alan Cox
-- strict thread matches above, loose matches on Subject: below --
2001-10-25 19:30 Samium Gromoff
2001-10-25 20:01 ` Benjamin LaHaise
2001-10-25 20:22 ` Alan Cox
2001-10-25 20:40 ` Martin Josefsson
2001-10-25 20:54 ` Alan Cox
2001-10-25 20:52 ` Benjamin LaHaise
2001-12-08 21:58 ` Samium Gromoff
2001-12-10 10:54 ` vda
2001-10-27 15:22 ` Jussi Laako
2001-10-27 15:50 ` Samium Gromoff
2001-10-25 20:21 ` Alan Cox
2001-10-25 21:19 ` Urban Widmark
2001-10-26 2:57 ` Samium Gromoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200112092304.fB9N4N008315@vegae.deep.net \
--to=_deepfire@mail.ru \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome