Re: 2.5.1-pre2 compile error in ide-scsi.o ide-scsi.c

Re: 2.5.1-pre2 compile error in ide-scsi.o ide-scsi.c

[Jens Axboe]

On Wed, Nov 28 2001, Sebastian Dröge wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi Jens,
> your patch doesn't work for ide-scsi
> I get this oops when trying to mount a CD:

[oops in sr_scatter_pad]

Hmm ok, and 2.5.1-pre1 works for you right?

-- 
Jens Axboe

Re: 2.5.1-pre2 compile error in ide-scsi.o ide-scsi.c

[Sebastian Dröge]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Mittwoch, 28. November 2001 14:58 schrieben Sie:
> On Wed, Nov 28 2001, Sebastian Dröge wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Hi Jens,
> > your patch doesn't work for ide-scsi
> > I get this oops when trying to mount a CD:
>
> [oops in sr_scatter_pad]
>
> Hmm ok, and 2.5.1-pre1 works for you right?

Yes it works very well
Bye
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8BO7uvIHrJes3kVIRAs+IAJwMg9ru+joRHR9ei6Sqd6GzKMQ6ogCgmZ7X
1J8gTk2dC84QXU4g5Abp12M=
=dPWQ
-----END PGP SIGNATURE-----

Re: 2.5.1-pre2 compile error in ide-scsi.o ide-scsi.c

[Jens Axboe]

On Wed, Nov 28 2001, Sebastian Dröge wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Am Mittwoch, 28. November 2001 14:58 schrieben Sie:
> > On Wed, Nov 28 2001, Sebastian Dröge wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > Hi Jens,
> > > your patch doesn't work for ide-scsi
> > > I get this oops when trying to mount a CD:
> >
> > [oops in sr_scatter_pad]
> >
> > Hmm ok, and 2.5.1-pre1 works for you right?
> 
> Yes it works very well

Ok, thanks for confirming that. Going to take a look at it now.

-- 
Jens Axboe

Re: 2.5.1-pre2 compile error in ide-scsi.o ide-scsi.c

[Jens Axboe]

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

On Wed, Nov 28 2001, Jens Axboe wrote:
> On Wed, Nov 28 2001, Sebastian Dröge wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> > 
> > Am Mittwoch, 28. November 2001 14:58 schrieben Sie:
> > > On Wed, Nov 28 2001, Sebastian Dröge wrote:
> > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > Hash: SHA1
> > > >
> > > > Hi Jens,
> > > > your patch doesn't work for ide-scsi
> > > > I get this oops when trying to mount a CD:
> > >
> > > [oops in sr_scatter_pad]
> > >
> > > Hmm ok, and 2.5.1-pre1 works for you right?
> > 
> > Yes it works very well
> 
> Ok, thanks for confirming that. Going to take a look at it now.

Does this work for you? Apply on top of what you already have.

-- 
Jens Axboe


[-- Attachment #2: sr-sg-1 --]
[-- Type: text/plain, Size: 1096 bytes --]

--- /opt/kernel/linux-2.5.1-pre2/drivers/scsi/sr.c	Wed Nov 28 09:13:59 2001
+++ drivers/scsi/sr.c	Wed Nov 28 15:33:25 2001
@@ -326,11 +326,14 @@
 	}
 	if (old_sg) {
 		memcpy(sg + i, old_sg, SCpnt->use_sg * sizeof(struct scatterlist));
-		memcpy(bbpnt + i, old_bbpnt, SCpnt->use_sg * sizeof(void *));
+		if (old_bbpnt)
+			memcpy(bbpnt + i, old_bbpnt, SCpnt->use_sg * sizeof(void *));
 		scsi_free(old_sg, (((SCpnt->use_sg * sizeof(struct scatterlist)) +
 				    (SCpnt->use_sg * sizeof(void *))) + 511) & ~511);
 	} else {
-		sg[i].address = SCpnt->request_buffer;
+		sg[i].address = NULL;
+		sg[i].page = virt_to_page(SCpnt->request_buffer);
+		sg[i].offset = (unsigned long) SCpnt->request_buffer&~PAGE_MASK;
 		sg[i].length = SCpnt->request_bufflen;
 	}
 
@@ -340,7 +343,9 @@
 	SCpnt->use_sg += i;
 
 	if (bsize) {
-		sg[SCpnt->use_sg].address = back;
+		sg[SCpnt->use_sg].address = NULL;
+		sg[SCpnt->use_sg].page = virt_to_page(back);
+		sg[SCpnt->use_sg].offset = (unsigned long) back & ~PAGE_MASK;
 		bbpnt[SCpnt->use_sg] = back;
 		sg[SCpnt->use_sg].length = bsize;
 		SCpnt->use_sg++;

Re: 2.5.1-pre2 compile error in ide-scsi.o ide-scsi.c

[Sebastian Dröge]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Mittwoch, 28. November 2001 15:37 schrieben Sie:
> On Wed, Nov 28 2001, Jens Axboe wrote:
> > On Wed, Nov 28 2001, Sebastian Dröge wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > Am Mittwoch, 28. November 2001 14:58 schrieben Sie:
> > > > On Wed, Nov 28 2001, Sebastian Dröge wrote:
> > > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > > Hash: SHA1
> > > > >
> > > > > Hi Jens,
> > > > > your patch doesn't work for ide-scsi
> > > > > I get this oops when trying to mount a CD:
> > > >
> > > > [oops in sr_scatter_pad]
> > > >
> > > > Hmm ok, and 2.5.1-pre1 works for you right?
> > >
> > > Yes it works very well
> >
> > Ok, thanks for confirming that. Going to take a look at it now.
>
> Does this work for you? Apply on top of what you already have.

Yes it does work :)
Thank you very much

BTW my patch does work, too in addition with the sr-sg patch ;) But Jens' is 
cleaner

Bye
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8BPo7vIHrJes3kVIRAqtJAJ9zDUEC3hOr/YrhD0u9ffDq+0Qu/gCgkCFO
BZ/hoLNeJn69teIN8L1msSI=
=lXPv
-----END PGP SIGNATURE-----

Re: 2.5.1-pre2 compile error in ide-scsi.o ide-scsi.c

[Slo Mo Snail]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Mittwoch, 28. November 2001 15:37 schrieben Sie:
> On Wed, Nov 28 2001, Jens Axboe wrote:
> > On Wed, Nov 28 2001, Sebastian Dröge wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > Am Mittwoch, 28. November 2001 14:58 schrieben Sie:
> > > > On Wed, Nov 28 2001, Sebastian Dröge wrote:
> > > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > > Hash: SHA1
> > > > >
> > > > > Hi Jens,
> > > > > your patch doesn't work for ide-scsi
> > > > > I get this oops when trying to mount a CD:
> > > >
> > > > [oops in sr_scatter_pad]
> > > >
> > > > Hmm ok, and 2.5.1-pre1 works for you right?
> > >
> > > Yes it works very well
> >
> > Ok, thanks for confirming that. Going to take a look at it now.
>
> Does this work for you? Apply on top of what you already have.

OK it does work BUT
when I read audio data from a CD it reads the first ~20 MB and then it 
doesn't write anything on hdd.
When I try to play an audio CD with the KDE CD player it crashes immediately
2.5.1-pre1 works fine and mounting/reading data CDs work, too
Bye
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8BjeSvIHrJes3kVIRAo8AAJsGac8MjYRteNLG7VU3eqJHacZAOACgrGqX
TfSiWC+4PeHJe08HFREgQy8=
=yOcb
-----END PGP SIGNATURE-----

Re: 2.5.1-pre2 compile error in ide-scsi.o ide-scsi.c

[Sebastian Dröge]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Donnerstag, 29. November 2001 14:26 schrieben Sie:
> Am Mittwoch, 28. November 2001 15:37 schrieben Sie:
> > On Wed, Nov 28 2001, Jens Axboe wrote:
> > > On Wed, Nov 28 2001, Sebastian Dröge wrote:
> > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > Hash: SHA1
> > > >
> > > > Am Mittwoch, 28. November 2001 14:58 schrieben Sie:
> > > > > On Wed, Nov 28 2001, Sebastian Dröge wrote:
> > > > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > > > Hash: SHA1
> > > > > >
> > > > > > Hi Jens,
> > > > > > your patch doesn't work for ide-scsi
> > > > > > I get this oops when trying to mount a CD:
> > > > >
> > > > > [oops in sr_scatter_pad]
> > > > >
> > > > > Hmm ok, and 2.5.1-pre1 works for you right?
> > > >
> > > > Yes it works very well
> > >
> > > Ok, thanks for confirming that. Going to take a look at it now.
> >
> > Does this work for you? Apply on top of what you already have.
>
> OK it does work BUT
> when I read audio data from a CD it reads the first ~20 MB and then it
> doesn't write anything on hdd.
> When I try to play an audio CD with the KDE CD player it crashes
> immediately 2.5.1-pre1 works fine and mounting/reading data CDs work, too
> Bye
But wait :)
I'll first test 2.5.1-pre3 + Alan's Patch + your sg-sr patch + your bio patch
Bye
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8Bjk4vIHrJes3kVIRAuLmAJ9wVsXe/S93b5in+3CyPl1QodIKPACeLtkx
qjsXfuO+dOOGPYoyyjgLfSE=
=lp5q
-----END PGP SIGNATURE-----

Re: 2.5.1-pre2 compile error in ide-scsi.o ide-scsi.c

[Slo Mo Snail]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Donnerstag, 29. November 2001 14:33 schrieben Sie:
> Am Donnerstag, 29. November 2001 14:26 schrieben Sie:
> > Am Mittwoch, 28. November 2001 15:37 schrieben Sie:
> > > On Wed, Nov 28 2001, Jens Axboe wrote:
> > > > On Wed, Nov 28 2001, Sebastian Dröge wrote:
> > > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > > Hash: SHA1
> > > > >
> > > > > Am Mittwoch, 28. November 2001 14:58 schrieben Sie:
> > > > > > On Wed, Nov 28 2001, Sebastian Dröge wrote:
> > > > > > > -----BEGIN PGP SIGNED MESSAGE-----
> > > > > > > Hash: SHA1
> > > > > > >
> > > > > > > Hi Jens,
> > > > > > > your patch doesn't work for ide-scsi
> > > > > > > I get this oops when trying to mount a CD:
> > > > > >
> > > > > > [oops in sr_scatter_pad]
> > > > > >
> > > > > > Hmm ok, and 2.5.1-pre1 works for you right?
> > > > >
> > > > > Yes it works very well
> > > >
> > > > Ok, thanks for confirming that. Going to take a look at it now.
> > >
> > > Does this work for you? Apply on top of what you already have.
> >
> > OK it does work BUT
> > when I read audio data from a CD it reads the first ~20 MB and then it
> > doesn't write anything on hdd.
> > When I try to play an audio CD with the KDE CD player it crashes
> > immediately 2.5.1-pre1 works fine and mounting/reading data CDs work, too
> > Bye
>
> But wait :)
> I'll first test 2.5.1-pre3 + Alan's Patch + your sg-sr patch + your bio
> patch Bye
Hmm it works :)
Thanks
I'll test some more things with my CD drives ;)
Maybe I'll find some bugs
Bye
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8BkEEvIHrJes3kVIRAvQ9AKCbVMNKEbz3mB2XgFo8BKzymui5jQCdGJiF
KoBQHL2kW05Mjiw9lsQi3xc=
=Q1R3
-----END PGP SIGNATURE-----

Re: 2.5.1-pre2 compile error in ide-scsi.o ide-scsi.c

[Jens Axboe]

On Thu, Nov 29 2001, Slo Mo Snail wrote:
> > But wait :)
> > I'll first test 2.5.1-pre3 + Alan's Patch + your sg-sr patch + your bio
> > patch Bye
> Hmm it works :)

Just to confirm -- 2.5.1-pre3 + Alan's patch + my bio-pre3-1 patch,
right? pre3 already contains the sg-sr part.

> I'll test some more things with my CD drives ;)
> Maybe I'll find some bugs

Please do :)

-- 
Jens Axboe

Re: 2.5.1-pre2 compile error in ide-scsi.o ide-scsi.c

[Sebastian Dröge]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Donnerstag, 29. November 2001 15:23 schrieben Sie:
> On Thu, Nov 29 2001, Slo Mo Snail wrote:
> > > But wait :)
> > > I'll first test 2.5.1-pre3 + Alan's Patch + your sg-sr patch + your bio
> > > patch Bye
> >
> > Hmm it works :)
>
> Just to confirm -- 2.5.1-pre3 + Alan's patch + my bio-pre3-1 patch,
> right? pre3 already contains the sg-sr part.
>
> > I'll test some more things with my CD drives ;)
> > Maybe I'll find some bugs
>
> Please do :)
Sorry my mistake
I've meant this patch: 
http://kernel.org/pub/linux/kernel/people/axboe/patches/v2.5/2.5.1-pre3/bio-pre3-1.gz

So it's 2.5.1-pre3 + Alan's patch + bio-pre3-1 + the patch you've posted 
after the 2.5.1-pre3 don't-use mail

There were no failures while patching so I think this patches are compatible 
each other ;)

And it works well... no data corruption, no oopses, no nothing ;)
Later the day I'll test burning a CD
Bye
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE8BkgVvIHrJes3kVIRAiQQAKCG0efeie+bKhbKe+BHXaI4XCCSuACfS7T/
806yy00KSYP+zID3ijLskfQ=
=idKY
-----END PGP SIGNATURE-----

Re: 2.5.1-pre2 compile error in ide-scsi.o ide-scsi.c

[Jens Axboe]

On Thu, Nov 29 2001, Sebastian Dröge wrote:
> Sorry my mistake
> I've meant this patch: 
> http://kernel.org/pub/linux/kernel/people/axboe/patches/v2.5/2.5.1-pre3/bio-pre3-1.gz
> 
> So it's 2.5.1-pre3 + Alan's patch + bio-pre3-1 + the patch you've posted 
> after the 2.5.1-pre3 don't-use mail
> 
> There were no failures while patching so I think this patches are compatible 
> each other ;)

Yes sure, that's what I expected. THe part I didn't understand was the
sr-sg-1 part.

> And it works well... no data corruption, no oopses, no nothing ;)
> Later the day I'll test burning a CD

Good

-- 
Jens Axboe

Unable to handle kernel NULL pointer dereference at virtual address 00000000 (Was: Re: 2.5.1-pre2 compile error in ide-scsi.o ide-scsi.c)

[Roger Larsson]

On Thursdayen den 29 November 2001 17.54, Jens Axboe wrote:
> On Thu, Nov 29 2001, Sebastian Dröge wrote:
> > Sorry my mistake
> > I've meant this patch:
> > http://kernel.org/pub/linux/kernel/people/axboe/patches/v2.5/2.5.1-pre3/b
> >io-pre3-1.gz
> >
> > So it's 2.5.1-pre3 + Alan's patch + bio-pre3-1 + the patch you've posted
> > after the 2.5.1-pre3 don't-use mail
> >
> > There were no failures while patching so I think this patches are
> > compatible each other ;)
>
> Yes sure, that's what I expected. THe part I didn't understand was the
> sr-sg-1 part.
>
> > And it works well... no data corruption, no oopses, no nothing ;)
> > Later the day I'll test burning a CD
>
> Good

Hmm...

I got the BUG described earlier in this thread with a 2.4.16 kernel (sligtly 
patched but in a different area - update the page structure referenced bit 
when scheduling away a process - it has been running for several days)

The driver in question is a "Pioneer DVD-ROM ATAPIModel DVD-115 0122"
And i tried to mount a Windows CD - Joliet?

It looks like this:

Dec 13 22:07:00 jeloin kernel: VFS: Disk change detected on device ide1(22,64)
Dec 13 22:07:03 jeloin kernel: Unable to handle kernel NULL pointer 
dereference at virtual address 00000000
Dec 13 22:07:03 jeloin kernel:  printing eip:
Dec 13 22:07:03 jeloin kernel: d0894866
Dec 13 22:07:03 jeloin kernel: *pde = 00000000
Dec 13 22:07:03 jeloin kernel: Oops: 0002
Dec 13 22:07:03 jeloin kernel: CPU:    0
Dec 13 22:07:03 jeloin kernel: EIP:    0010:[<d0894866>]    Not tainted
Dec 13 22:07:03 jeloin kernel: EFLAGS: 00210202
Dec 13 22:07:03 jeloin kernel: eax: cf8b4600   ebx: 00000001   ecx: c6fa3000  
 edx: cbceb040
Dec 13 22:07:03 jeloin kernel: esi: c6fa3000   edi: 00000000   ebp: c7ad0f60  
 esp: c8403e88
Dec 13 22:07:03 jeloin kernel: ds: 0018   es: 0018   ss: 0018
Dec 13 22:07:03 jeloin kernel: Process kdeinit (pid: 1195, stackpage=c8403000)
Dec 13 22:07:03 jeloin kernel: Stack: 00000001 c6fa3000 c6fa3021 c7ad0f60 
00001640 00000000 00000000 00000000
Dec 13 22:07:03 jeloin kernel:        00000000 00000000 00000000 00000800 
cbceb040 d089227e c6fa3000 00000000
Dec 13 22:07:03 jeloin kernel:        cbceb040 c12bc640 cbceb040 cbceb040 
c7702360 00000030 00000030 00000000
Dec 13 22:07:03 jeloin kernel: Call Trace: [<d089227e>] [<d08923c4>] 
[real_lookup+83/196] [link_path_walk+1302/1880] [getname+93/156]
Dec 13 22:07:03 jeloin kernel:    [path_walk+26/28] [__user_walk+53/80] 
[sys_access+148/300] [system_call+51/56]
Dec 13 22:07:03 jeloin kernel:
Dec 13 22:07:03 jeloin kernel: Code: c6 07 00 0f b6 51 20 8d 42 21 89 44 24 
30 83 e0 01 83 c2 22
Dec 13 22:09:19 jeloin modprobe: modprobe: Can't locate module net-pf-10

I have ide-scsi but that is only used on my CDRW 
"Vendor: HP       Model: CD-Writer+ 9300  Rev: 1.0c"

Ideas?

/RogerL

-- 
Roger Larsson
Skellefteå
Sweden

Re: Unable to handle kernel NULL pointer dereference at virtual address 00000000 (Was: Re: 2.5.1-pre2 compile error in ide-scsi.o ide-scsi.c)

[Roger Larsson]

On Thursdayen den 13 December 2001 22.28, Roger Larsson wrote:
> Hmm...
>
> I got the BUG described earlier in this thread with a 2.4.16 kernel
> (sligtly patched but in a different area - update the page structure
> referenced bit when scheduling away a process - it has been running for
> several days)

Following up to myself :--(

There was an additional patch that I had forgotten.
It might cause allocation failures (due to slower movement between lists)
 - but no such thing were indicated in the messages...
And why should it only happen when trying to mount?
(could be the patches again - some kind of version mismatch...)

Now running 2.4.17-rc1 and trying to reproduce it.
I have not succeded yet :-)

/RogerL
-- 
Roger Larsson
Skellefteå
Sweden