[PATCH] Bogus devfs ChangeLog change in 2.5.2-pre4

[PATCH] Bogus devfs ChangeLog change in 2.5.2-pre4

[Richard Gooch]

  Hi, Linus. Someone sneaked the appended patch into 2.5.2-pre4, which
is not necessary and obviously wrong (the ChangeLog was correct
previously). Please revert.

Looks like the result of an automated global search-and-replace
(i.e. lazy cleanup). Pity a sanity a last-minute sanity check wasn't
performed by the guilty party.
</grumble>

				Regards,

					Richard....
Permanent: rgooch@atnf.csiro.au
Current:   rgooch@ras.ucalgary.ca

diff -urN linux-2.5.2-pre3/fs/devfs/base.c linux/fs/devfs/base.c
--- linux-2.5.2-pre3/fs/devfs/base.c	Sun Dec 30 11:38:08 2001
+++ linux/fs/devfs/base.c	Sun Dec 30 11:38:12 2001
@@ -517,7 +517,6 @@
     20010730   Richard Gooch <rgooch@atnf.csiro.au>
 	       Added DEVFSD_NOTIFY_DELETE event.
     20010801   Richard Gooch <rgooch@atnf.csiro.au>
-	       Removed #include <asm/segment.h>.
   v0.109
     20010807   Richard Gooch <rgooch@atnf.csiro.au>
 	       Fixed inode table races by removing it and using

Re: [PATCH] Bogus devfs ChangeLog change in 2.5.2-pre4

[Russell King]

On Sun, Dec 30, 2001 at 01:14:19PM -0700, Richard Gooch wrote:
>   Hi, Linus. Someone sneaked the appended patch into 2.5.2-pre4, which
> is not necessary and obviously wrong (the ChangeLog was correct
> previously). Please revert.
> 
> Looks like the result of an automated global search-and-replace
> (i.e. lazy cleanup). Pity a sanity a last-minute sanity check wasn't
> performed by the guilty party.
> </grumble>

That's not the only thing.  There's also a load of:

#else
#endif

constructs now as well that need cleaning up.

-- 
Russell King (rmk@arm.linux.org.uk)                The developer of ARM Linux
             http://www.arm.linux.org.uk/personal/aboutme.html

Re: [PATCH] Bogus devfs ChangeLog change in 2.5.2-pre4

[Dave Jones]

On Sun, 30 Dec 2001, Richard Gooch wrote:

>   Hi, Linus. Someone sneaked the appended patch into 2.5.2-pre4, which
> is not necessary and obviously wrong (the ChangeLog was correct
> previously). Please revert.
>
> Looks like the result of an automated global search-and-replace
> (i.e. lazy cleanup). Pity a sanity a last-minute sanity check wasn't
> performed by the guilty party.

dwmw2's handywork from my tree.
I read this diff a half dozen times, and given Linus' scrutiny over the
other bits I've shoved him today, I guess he overlooked it too..
Typically, I spotted it whilst merging pre4 with my tree.. Weirdness.

Dave.

-- 
| Dave Jones.        http://www.codemonkey.org.uk
| SuSE Labs