mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* 2.5.3-pre1 build error and possible fix for net/ipv4/netfilter/ip_fw_compat_redir.c
@ 2002-01-17 16:58 Steven Cole
  2002-01-17 21:12 ` David S. Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Steven Cole @ 2002-01-17 16:58 UTC (permalink / raw)
  To: davem; +Cc: linux-kernel

I got the following error building 2.5.3-pre1.

ip_fw_compat_redir.c: In function `check_for_redirect':
ip_fw_compat_redir.c:274: too many arguments to function `add_timer'
ip_fw_compat_redir.c: In function `check_for_unredirect':
ip_fw_compat_redir.c:300: too many arguments to function `add_timer'
make[3]: *** [ip_fw_compat_redir.o] Error 1

Here is a proposed fix.  I looked at how add_timer was used earlier in the file.

Steven

--- linux/net/ipv4/netfilter/ip_fw_compat_redir.c.original	Tue Jan 15 14:35:45 2002
+++ linux/net/ipv4/netfilter/ip_fw_compat_redir.c	Thu Jan 17 09:40:58 2002
@@ -270,8 +270,10 @@
 	if (redir) {
 		DEBUGP("Doing tcp redirect again.\n");
 		do_tcp_redir(skb, redir);
-		if (del_timer(&redir->destroyme))
-			add_timer(&redir->destroyme, jiffies + REDIR_TIMEOUT);
+		if (del_timer(&redir->destroyme)) {
+			redir->destroyme.expires = jiffies + REDIR_TIMEOUT;
+			add_timer(&redir->destroyme);
+			}
 	}
 	UNLOCK_BH(&redir_lock);
 }
@@ -296,8 +298,10 @@
 	if (redir) {
 		DEBUGP("Doing tcp unredirect.\n");
 		do_tcp_unredir(skb, redir);
-		if (del_timer(&redir->destroyme))
-			add_timer(&redir->destroyme, jiffies + REDIR_TIMEOUT);
+		if (del_timer(&redir->destroyme)) {
+			redir->destroyme.expires = jiffies + REDIR_TIMEOUT;
+			add_timer(&redir->destroyme);
+			}
 	}
 	UNLOCK_BH(&redir_lock);
 }

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-01-17 21:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-01-17 16:58 2.5.3-pre1 build error and possible fix for net/ipv4/netfilter/ip_fw_compat_redir.c Steven Cole
2002-01-17 21:12 ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®