Re: [PATCH] amiga input api drivers

[Vojtech Pavlik <vojtech@suse.cz>]

On Thu, Jan 31, 2002 at 09:54:51PM +0100, Geert Uytterhoeven wrote:
> On Thu, 31 Jan 2002, James Simmons wrote:
> >   The amiga mouse and amiga joystick have been already ported over to the
> > input api. Now for the keyboard. This patch is the input api amiga
> > keyboard. I wanted people to try it out before I send it off to be
> > included in the DJ tree. Have fun!!!
> 
> > diff -urN -X /home/jsimmons/dontdiff linux-2.5.2-dj7/drivers/input/keyboard/amikbd.c linux/drivers/input/keyboard/amikbd.c
> > --- linux-2.5.2-dj7/drivers/input/keyboard/amikbd.c	Wed Dec 31 16:00:00 1969
> > +++ linux/drivers/input/keyboard/amikbd.c	Thu Jan 31 07:44:05 2002
> 
> > +static char *amikbd_messages[] = {
> > +	KERN_ALERT "amikbd: Ctrl-Amiga-Amiga reset warning!!\n",
> > +	KERN_WARNING "amikbd: keyboard lost sync\n",
> > +	KERN_WARNING "amikbd: keyboard buffer overflow\n",
> > +	KERN_WARNING "amikbd: keyboard controller failure\n",
> > +	KERN_ERR "amikbd: keyboard selftest failure\n",
> > +	KERN_INFO "amikbd: initiate power-up key stream\n",
> > +	KERN_INFO "amikbd: terminate power-up key stream\n",
> > +	KERN_WARNING "amikbd: keyboard interrupt\n"
> > +};
> 
> > +	if (scancode < 0x78) {		/* scancodes < 0x78 are keys */
> 
>   [...]
> 
> > +	}
> > +
> > +	printk(amikbd_messages[scancode]);	/* scancodes >= 0x78 are error codes */
> 
> Oops, amikbd_messages[scancode-0x78]?

Thanks. And thanks to James for fixing this in the CVS as well.
Does it work otherwise?

-- 
Vojtech Pavlik
SuSE Labs