mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roman Zippel <zippel@linux-m68k.org>
To: James Simmons <jsimmons@transvirtual.com>
Cc: linux-m68k@lists.linux-m68k.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] amiga input api drivers
Date: Thu, 31 Jan 2002 22:50:46 +0100	[thread overview]
Message-ID: <3C59BC36.14267AE7@linux-m68k.org> (raw)
In-Reply-To: <Pine.LNX.4.10.10201310712130.20956-100000@www.transvirtual.com>

Hi,

James Simmons wrote:

> +       printk(amikbd_messages[scancode]);      /* scancodes >= 0x78 are error codes */

Damn, Geert was faster with this. :)

> +       for (i = 0; i < 0x78; i++)
> +               if (amikbd_keycode[i])
> +                       set_bit(amikbd_keycode[i], amikbd_dev.keybit);

Do I understand it correctly, that amikbd_keycode[i] must have non zero
value for a valid key? If yes, something must be wrong here:

> +static unsigned char amikbd_keycode[0x78] = {
> +         0,  2,  3,  4,  5,  6,  7,  8,  9, 10, 11, 12, 13, 43,  0, 82,

0 is a valid keycode on the Amiga, it should be KEY_GRAVE.

bye, Roman

  parent reply	other threads:[~2002-01-31 21:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-01-31 15:14 James Simmons
2002-01-31 20:54 ` Geert Uytterhoeven
2002-02-01  7:14   ` Vojtech Pavlik
2002-02-01  9:11     ` Geert Uytterhoeven
2002-01-31 21:18 ` Simon Richter
2002-01-31 23:44   ` James Simmons
2002-01-31 23:56     ` Simon Richter
2002-02-01  0:09     ` Roman Zippel
2002-02-01  0:12       ` James Simmons
2002-02-01  0:22       ` [PATCH] amiga input api drivers III James Simmons
2002-02-01  9:18         ` Geert Uytterhoeven
2002-02-01  0:46       ` [PATCH] amiga input api drivers Simon Richter
2002-02-01  9:10         ` Geert Uytterhoeven
2002-02-13 18:01           ` James Simmons
2002-02-13 18:10             ` Simon Richter
2002-02-13 19:25               ` James Simmons
2002-02-14  6:53                 ` Horst von Brand
2002-02-14 20:29                   ` James Simmons
2002-02-13 18:14             ` Geert Uytterhoeven
2002-01-31 21:50 ` Roman Zippel [this message]
2002-01-31 23:05   ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3C59BC36.14267AE7@linux-m68k.org \
    --to=zippel@linux-m68k.org \
    --cc=jsimmons@transvirtual.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®