From: Jeff Garzik <garzik@havoc.gtf.org>
To: Francois Romieu <romieu@cogenit.fr>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Krzysztof Halasa <khc@pm.waw.pl>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@transmeta.com>,
davem@redhat.com
Subject: Re: [PATCH] Generic HDLC patch for 2.5.3
Date: Sun, 3 Feb 2002 12:46:14 -0500 [thread overview]
Message-ID: <20020203124614.A10139@havoc.gtf.org> (raw)
In-Reply-To: <20020202190242.C1740@havoc.gtf.org> <E16XAnc-00010K-00@the-village.bc.nu> <20020202200332.A3740@havoc.gtf.org> <20020203181302.C12963@fafner.intra.cogenit.fr>
In-Reply-To: <20020203181302.C12963@fafner.intra.cogenit.fr>; from romieu@cogenit.fr on Sun, Feb 03, 2002 at 06:13:02PM +0100
I like. This patch much improves things.
"SIOCDEVICE" as a constant is unacceptable, so it would need to be
SIOCWANDEVICE or something similar.
SIOCETHTOOL, for example, is an ioctl which actually provides
sub-ioctls, so that is probably a good model to follow.
More comments after I return from New York, and can review these at
length...
Jeff
next prev parent reply other threads:[~2002-02-03 17:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-02 23:33 Krzysztof Halasa
2002-02-03 0:02 ` Jeff Garzik
2002-02-03 0:46 ` Alan Cox
2002-02-03 1:03 ` Jeff Garzik
2002-02-03 17:13 ` Francois Romieu
2002-02-03 17:46 ` Jeff Garzik [this message]
2002-02-03 22:06 ` Francois Romieu
2002-02-04 12:58 ` Krzysztof Halasa
2002-02-04 18:11 ` Francois Romieu
2002-02-05 12:11 ` Krzysztof Halasa
2002-02-04 12:46 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020203124614.A10139@havoc.gtf.org \
--to=garzik@havoc.gtf.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@redhat.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=romieu@cogenit.fr \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®