From: Steven Cole <elenstev@mesatop.com>
To: linux-kernel@vger.kernel.org
Cc: Gerd Knorr <kraxel@goldbach.in-berlin.de>
Subject: [PATCH] 2.5.5-pre1 fix build error in drivers/video/vesafb.c
Date: Thu, 14 Feb 2002 08:47:52 -0700 [thread overview]
Message-ID: <200202141501.IAA04461@tstac.esa.lanl.gov> (raw)
Hello all,
This patch is some hackery-quackery to fix a problem with drivers/video/vesafb.c.
I got the following error building 2.5.5-pre1. I also had this error with 2.5.4-preX,
but after seeing the discussions relating to bus_to_virt etc., I hoped that a
real fix would appear.
drivers/video/video.o: In function `vesafb_init':
drivers/video/video.o(.text.init+0x154b): undefined reference to `bus_to_virt_not_defined_use_pci_map'
make: *** [vmlinux] Error 1
Quoting Andrew Morton in his recent interview with kerneltrap.org,
"One hot tip: if you spot a bug which is being ignored, send a completely botched fix
to the mailing list. This causes thousands of kernel developers to rally to the cause.
Nobody knows why this happens. (I really have deliberately done this several times. It works)."
Well this bug is certainly not being ignored, but here is my completely botched fix.
Cheers,
Steven
--- linux-2.5.5-pre1/drivers/video/vesafb.c.orig Thu Feb 14 08:16:25 2002
+++ linux-2.5.5-pre1/drivers/video/vesafb.c Thu Feb 14 08:17:24 2002
@@ -550,7 +550,7 @@
ypan = pmi_setpal = 0; /* not available or some DOS TSR ... */
if (ypan || pmi_setpal) {
- pmi_base = (unsigned short*)bus_to_virt(((unsigned long)screen_info.vesapm_seg << 4) + screen_info.vesapm_off);
+ pmi_base = (unsigned short*)phys_to_virt(((unsigned long)screen_info.vesapm_seg << 4) + screen_info.vesapm_off);
pmi_start = (void*)((char*)pmi_base + pmi_base[1]);
pmi_pal = (void*)((char*)pmi_base + pmi_base[2]);
printk(KERN_INFO "vesafb: pmi: set display start = %p, set palette = %p\n",pmi_start,pmi_pal);
next reply other threads:[~2002-02-14 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-14 15:47 Steven Cole [this message]
2002-02-14 16:37 ` Gerd Knorr
2002-02-14 17:02 ` Steven Cole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200202141501.IAA04461@tstac.esa.lanl.gov \
--to=elenstev@mesatop.com \
--cc=kraxel@goldbach.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®