From: Gerd Knorr <kraxel@strusel007.de>
To: Steven Cole <elenstev@mesatop.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.5-pre1 fix build error in drivers/video/vesafb.c
Date: Thu, 14 Feb 2002 17:37:05 +0100 [thread overview]
Message-ID: <20020214163705.GA2185@goldbach.in-berlin.de> (raw)
In-Reply-To: <200202141501.IAA04461@tstac.esa.lanl.gov>
In-Reply-To: <200202141501.IAA04461@tstac.esa.lanl.gov>
> - pmi_base = (unsigned short*)bus_to_virt(((unsigned long)screen_info.vesapm_seg << 4) + screen_info.vesapm_off);
> + pmi_base = (unsigned short*)phys_to_virt(((unsigned long)screen_info.vesapm_seg << 4) + screen_info.vesapm_off);
Looks fine to me. While s/bus/phys/ isn't the approximate fix for many
drivers, at this place it is correct. The address is a segment:offset
pointer to a physical memory address somewhere in the VESA BIOS.
Gerd
--
Man muß die Software wacker hüten
weil in der Welt die Hacker wüten
next prev parent reply other threads:[~2002-02-14 16:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-14 15:47 Steven Cole
2002-02-14 16:37 ` Gerd Knorr [this message]
2002-02-14 17:02 ` Steven Cole
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020214163705.GA2185@goldbach.in-berlin.de \
--to=kraxel@strusel007.de \
--cc=elenstev@mesatop.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®