mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@turbolabs.com>
To: Martin Dalecki <dalecki@evision-ventures.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org
Subject: Re: ext3 and undeletion
Date: Tue, 26 Feb 2002 10:54:06 -0700	[thread overview]
Message-ID: <20020226105406.I12832@lynx.adilger.int> (raw)
In-Reply-To: <fa.n4lfl6v.h4chor@ifi.uio.no> <05cb01c1be1e$c490ba00$1a01a8c0@allyourbase> <20020225172048.GV20060@matchmail.com> <02022518330103.01161@grumpersII> <a5f7s4$2o1$1@cesium.transmeta.com> <20020226160544.GD4393@matchmail.com> <3C7BB9A3.30408@evision-ventures.com> <20020226164316.GH4393@matchmail.com> <3C7BBDE2.8050207@evision-ventures.com> <20020226170520.GJ4393@matchmail.com>
In-Reply-To: <20020226170520.GJ4393@matchmail.com>; from mfedyk@matchmail.com on Tue, Feb 26, 2002 at 09:05:20AM -0800

On Feb 26, 2002  09:05 -0800, Mike Fedyk wrote:
> On Tue, Feb 26, 2002 at 05:54:58PM +0100, Martin Dalecki wrote:
> > For the educated user it was always a pain
> > in the you know where, to constantly run out of quota space due to
> > file versioning.
> 
> Ahh, so we'd need to chown the files to root (or a configurable user and
> group) to get around the quota issue.

Well, I don't agree with changing file ownership, because _any_ way around
the quota system will be exploited by users (e.g. deleting files temporarily
to gain more space, and hope they aren't destroyed before they need them
again).  It also opens a huge can of worms security wise, because it may
be possible for one user to undelete files belonging to another user if
you are not super careful.

No, I would have the unlink wrapper/daemon be quota-aware, and if a user
is getting close to filling their quota then it would delete more of that
user's files from the undelete directory, just as if the entire fs was
getting full or the user had hit their preconfigured limit for maximum
undelete size or versions of a file.  Since the unlink call will never
_increase_ the amount of disk used by a user (it is simply a rename()
in disguise) this in itself can't be the cause a quota problem.

The only potential problem would be if the cleanup daemon dies.  In that
case, a user should still be able to do something like "unrm --purge" to
manually clean up his files in the undelete tree (or "unrm -ls <filespec>"
to show files and "unrm -d <file...>" to really delete individual ones).

For people who don't want to have undelete at all (for whatever reason)
can always have something like "max_undelete=0" in their .unrmrc file,
or just not use it in the first place.

Cheers, Andreas
--
Andreas Dilger
http://sourceforge.net/projects/ext2resize/
http://www-mddsp.enel.ucalgary.ca/People/adilger/


  parent reply	other threads:[~2002-02-26 17:55 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.n4lfl6v.h4chor@ifi.uio.no>
2002-02-25 17:06 ` Dan Maas
2002-02-25 17:20   ` Mike Fedyk
2002-02-25 23:33     ` Tom Rauschenbach
2002-02-26  0:27       ` Bernd Eckenfels
2002-02-26  5:53       ` H. Peter Anvin
2002-02-26 16:05         ` Mike Fedyk
2002-02-26 16:31           ` H. Peter Anvin
2002-02-26 16:40             ` Mike Fedyk
2002-02-26 16:55               ` H. Peter Anvin
2002-02-26 17:12                 ` Mike Fedyk
2002-02-26 16:36           ` Martin Dalecki
2002-02-26 16:43             ` Mike Fedyk
2002-02-26 16:54               ` Martin Dalecki
2002-02-26 17:05                 ` Mike Fedyk
2002-02-26 17:07                   ` Martin Dalecki
2002-02-26 17:16                     ` Mike Fedyk
2002-02-26 17:22                       ` Rik van Riel
2002-02-26 17:38                         ` Mike Fedyk
2002-02-26 18:14                           ` Andreas Ferber
2002-02-26 18:55                             ` Andreas Dilger
2002-02-26 22:04                           ` Mike Fedyk
2002-02-26 18:34                       ` Richard B. Johnson
2002-02-26 18:34                         ` H. Peter Anvin
2002-02-26 18:47                           ` Richard B. Johnson
2002-02-26 18:52                         ` Andreas Dilger
2002-02-28 15:05                         ` Andreas Ferber
2002-02-28 22:37                           ` Andreas Dilger
2002-03-01  4:44                           ` Mike Fedyk
2002-03-04 16:26                           ` Pavel Machek
2002-03-05 21:29                             ` Andreas Ferber
2002-03-06 11:30                               ` Pavel Machek
2002-03-05 22:07                             ` Richard B. Johnson
2002-02-28 22:55                         ` James D Strandboge
2002-02-26 17:22                     ` Mike Fedyk
2002-03-01  0:19                       ` Rick Lindsley
2002-03-01  1:02                         ` Andreas Dilger
2002-02-26 17:54                   ` Andreas Dilger [this message]
2002-02-26 18:24                 ` Alan Cox
2002-03-04 15:40     ` Pavel Machek
2002-02-25 18:08   ` Richard B. Johnson
2002-02-25 18:40     ` Mike Fedyk
2002-02-25 19:49       ` Andreas Dilger
2002-02-25 22:05         ` ext3 and undeletion (libtrash) Omen Wild
2002-03-05 23:04 ext3 and undeletion Rose, Billy
2002-03-06 20:03 ` Mark Mielke
2002-03-07 21:30 ` Patrick Lynch
  -- strict thread matches above, loose matches on Subject: below --
2002-02-28 10:37 Randal, Phil
2002-02-26 18:39 Dana Lacoste
2002-02-26 18:47 ` Daniel Gryniewicz
2002-02-26 18:51 ` David Lang
2002-02-26 17:48 Rose, Billy
2002-02-26 17:53 ` Martin Dalecki
2002-02-26 18:03   ` Mike Fedyk
2002-02-26 17:56 ` Rik van Riel
2002-02-26 19:41   ` Andreas Dilger
2002-02-26 18:00 ` H. Peter Anvin
2002-02-26 18:15   ` Andreas Dilger
2002-02-26 18:23     ` Jakob Østergaard
2002-02-26 18:19   ` David Lang
2002-02-26 18:29 ` Andreas Ferber
2002-02-27 21:00 ` James D Strandboge
2002-02-27 21:40   ` Alan Cox
2002-02-27 22:16     ` James D Strandboge
2002-02-27 22:33       ` Alan Cox
2002-02-27 23:03         ` James D Strandboge
2002-02-28  0:29         ` James D Strandboge
2002-03-04  2:17         ` Mike Fedyk
2002-03-04 15:12           ` Alan Cox
2002-03-04 15:33             ` Mike Fedyk
2002-03-04 19:17             ` James D Strandboge
2002-03-04 20:08               ` Jesse Pollard
2002-03-02 17:36   ` Pablo Alcaraz
2002-02-25 16:46 Rose, Billy
2002-02-25  3:27 Steven Walter
2002-02-25  5:08 ` Andreas Dilger
2002-02-25 10:16 ` Fabrice Bellet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020226105406.I12832@lynx.adilger.int \
    --to=adilger@turbolabs.com \
    --cc=dalecki@evision-ventures.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®