mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "christophe barbé" <christophe.barbe.ml@online.fr>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Andrew Morton <akpm@zip.com.au>
Subject: Re: 3c59x and cardbus
Date: Tue, 26 Feb 2002 18:00:10 -0500	[thread overview]
Message-ID: <20020226230010.GI803@ufies.org> (raw)
In-Reply-To: <20020226173038.GD803@ufies.org> <3C7BC897.8D607D08@zip.com.au> <20020226175819.GE803@ufies.org> <20020226181510.GF803@ufies.org> <3C7BD91C.3B758704@zip.com.au> <20020226185907.GG803@ufies.org>
In-Reply-To: <20020226185907.GG803@ufies.org>

[-- Attachment #1: Type: text/plain, Size: 3219 bytes --]

Now that the forget_option bug is solved I have the following :

Each time I suspend, the card resume in a bad state but return in a good
state after that :

NETDEV WATCHDOG: eth0: transmit timed out
eth0: transmit timed out, tx_status 00 status e000.
  diagnostics: net 0ee0 media 8800 dma 000000a0.
  Flags; bus-master 1, dirty 20(4) current 36(4)
  Transmit list 00af8300 vs. c0af8300.
  0: @c0af8200  length 80000062 status 00000062
  1: @c0af8240  length 80000062 status 00000062
  2: @c0af8280  length 80000062 status 80000062
  3: @c0af82c0  length 80000062 status 80000062
  4: @c0af8300  length 80000062 status 00000062
  5: @c0af8340  length 8000003c status 0000003c
  6: @c0af8380  length 80000062 status 00000062
  7: @c0af83c0  length 80000062 status 00000062
  8: @c0af8400  length 8000003c status 0000003c
  9: @c0af8440  length 80000062 status 00000062
  10: @c0af8480  length 80000062 status 00000062
  11: @c0af84c0  length 80000036 status 00000036
  12: @c0af8500  length 80000062 status 00000062
  13: @c0af8540  length 80000062 status 00000062
  14: @c0af8580  length 80000062 status 00000062
  15: @c0af85c0  length 80000062 status 00000062
eth0: Resetting the Tx ring pointer.

The tx ring seems to be in a good state, no ?

Christophe

On Tue, Feb 26, 2002 at 01:59:07PM -0500, christophe barbé wrote:
> Thank you, I have done something similar and that solve it in my case at
> least. This driver was clearly not designed for cardbus.
> 
> I am still looking for my resume/suspend problem.
> Hope to find the solution soon.
> 
> Christophe
> 
> On Tue, Feb 26, 2002 at 10:51:08AM -0800, Andrew Morton wrote:
> > christophe barbé wrote:
> > > 
> > > Ok I have found why.
> > > When I resinsert the card, the driver give it a new id (this driver
> > > supports multiple cards) and the option as I set it is only defined for
> > > the card #0. I would expect that the driver give the same id back.
> > > 
> > 
> > hrm.  OK, hotplugging and slot-positional module parameters weren't
> > designed to live together.
> > 
> > This should fix it for single cards.   For multiple cards, you'll
> > have to make sure you eject them in reverse scan order :)
> > 
> > Index: drivers/net/3c59x.c
> > ===================================================================
> > RCS file: /opt/cvs/lk/drivers/net/3c59x.c,v
> > retrieving revision 1.74.2.7
> > diff -u -r1.74.2.7 3c59x.c
> > --- drivers/net/3c59x.c	2002/02/13 21:03:03	1.74.2.7
> > +++ drivers/net/3c59x.c	2002/02/26 18:49:24
> > @@ -2898,6 +2898,9 @@
> >  		BUG();
> >  	}
> >  
> > +	if (vp->card_idx == vortex_cards_found)
> > +		vortex_cards_found--;
> > +
> >  	vp = dev->priv;
> >  
> >  	/* AKPM: FIXME: we should have
> > 
> > 
> > -
> 
> -- 
> Christophe Barbé <christophe.barbe@ufies.org>
> GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E
> 
> Imagination is more important than knowledge.
>    Albert Einstein, On Science



-- 
Christophe Barbé <christophe.barbe@ufies.org>
GnuPG FingerPrint: E0F6 FADF 2A5C F072 6AF8  F67A 8F45 2F1E D72C B41E

Imagination is more important than knowledge.
   Albert Einstein, On Science

[-- Attachment #2: Type: application/pgp-signature, Size: 241 bytes --]

  reply	other threads:[~2002-02-26 23:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-26 17:30 christophe barbé
2002-02-26 17:40 ` Andrew Morton
2002-02-26 17:58   ` christophe barbé
2002-02-26 18:15     ` christophe barbé
2002-02-26 18:51       ` Andrew Morton
2002-02-26 18:59         ` christophe barbé
2002-02-26 23:00           ` christophe barbé [this message]
2002-02-26 23:32             ` Andrew Morton
2002-02-26 23:38               ` christophe barbé
2002-03-02 21:08               ` christophe barbé
2002-02-27  0:29             ` Pozsar Balazs
2002-02-27  0:32               ` nick
2002-02-27  0:41                 ` christophe barbé
2002-02-27  0:43                 ` Pozsar Balazs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020226230010.GI803@ufies.org \
    --to=christophe.barbe.ml@online.fr \
    --cc=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®