From: Andrew Morton <akpm@zip.com.au>
To: "christophe barbé" <christophe.barbe.ml@online.fr>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: 3c59x and cardbus
Date: Tue, 26 Feb 2002 10:51:08 -0800 [thread overview]
Message-ID: <3C7BD91C.3B758704@zip.com.au> (raw)
In-Reply-To: <20020226173038.GD803@ufies.org> <3C7BC897.8D607D08@zip.com.au> <20020226175819.GE803@ufies.org>, <20020226175819.GE803@ufies.org> <20020226181510.GF803@ufies.org>
christophe barbé wrote:
>
> Ok I have found why.
> When I resinsert the card, the driver give it a new id (this driver
> supports multiple cards) and the option as I set it is only defined for
> the card #0. I would expect that the driver give the same id back.
>
hrm. OK, hotplugging and slot-positional module parameters weren't
designed to live together.
This should fix it for single cards. For multiple cards, you'll
have to make sure you eject them in reverse scan order :)
Index: drivers/net/3c59x.c
===================================================================
RCS file: /opt/cvs/lk/drivers/net/3c59x.c,v
retrieving revision 1.74.2.7
diff -u -r1.74.2.7 3c59x.c
--- drivers/net/3c59x.c 2002/02/13 21:03:03 1.74.2.7
+++ drivers/net/3c59x.c 2002/02/26 18:49:24
@@ -2898,6 +2898,9 @@
BUG();
}
+ if (vp->card_idx == vortex_cards_found)
+ vortex_cards_found--;
+
vp = dev->priv;
/* AKPM: FIXME: we should have
-
next prev parent reply other threads:[~2002-02-26 18:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-26 17:30 christophe barbé
2002-02-26 17:40 ` Andrew Morton
2002-02-26 17:58 ` christophe barbé
2002-02-26 18:15 ` christophe barbé
2002-02-26 18:51 ` Andrew Morton [this message]
2002-02-26 18:59 ` christophe barbé
2002-02-26 23:00 ` christophe barbé
2002-02-26 23:32 ` Andrew Morton
2002-02-26 23:38 ` christophe barbé
2002-03-02 21:08 ` christophe barbé
2002-02-27 0:29 ` Pozsar Balazs
2002-02-27 0:32 ` nick
2002-02-27 0:41 ` christophe barbé
2002-02-27 0:43 ` Pozsar Balazs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3C7BD91C.3B758704@zip.com.au \
--to=akpm@zip.com.au \
--cc=christophe.barbe.ml@online.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®