From: Christoph Hellwig <hch@ns.caldera.de>
To: andrea@suse.de (Andrea Arcangeli)
Cc: linux-kernel@vger.kernel.org, Andrew Morton <andrewm@uow.edu.au>
Subject: Re: vm-28 for 2.4.19pre1
Date: Thu, 28 Feb 2002 20:07:30 +0100 [thread overview]
Message-ID: <200202281907.g1SJ7Ul16828@ns.caldera.de> (raw)
In-Reply-To: <20020228174607.X1705@inspiron.school.suse.de>
Hi Andrea,
In article <20020228174607.X1705@inspiron.school.suse.de> you wrote:
> This patch includes all my latest VM developement against 2.4.19pre1. I
> would suggest it for inclusion in pre2. I don't have the time right now
> to split it into little pieces, but I can do that in the weekend or next
> week if you prefer (tomorrow I'll be offline).
>
> ftp://ftp.us.kernel.org/pub/linux/kernel/people/andrea/patches/v2.4/2.4.19pre1/vm-28
Could you actually explain what it changes, especially as it isn't
really commented very well..
Despite of the above I already have some nitpicks:
- couldn't you make inc_nr_active_pages/dec_nr_active_pages/
inc_nr_inactive_pages/dec_nr_inactive_pages inlines?
The current macro abuse isn't nice.
- in mm/memory.c (the 1141 chunk) you introduced a race.
--
Of course it doesn't work. We've performed a software upgrade.
next prev parent reply other threads:[~2002-02-28 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-28 16:46 Andrea Arcangeli
2002-02-28 15:41 ` Marcelo Tosatti
2002-02-28 19:07 ` Christoph Hellwig [this message]
2002-03-02 1:23 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200202281907.g1SJ7Ul16828@ns.caldera.de \
--to=hch@ns.caldera.de \
--cc=andrea@suse.de \
--cc=andrewm@uow.edu.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®