From: Andrea Arcangeli <andrea@suse.de>
To: Christoph Hellwig <hch@ns.caldera.de>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <andrewm@uow.edu.au>
Subject: Re: vm-28 for 2.4.19pre1
Date: Sat, 2 Mar 2002 02:23:01 +0100 [thread overview]
Message-ID: <20020302022301.B4431@inspiron.random> (raw)
In-Reply-To: <20020228174607.X1705@inspiron.school.suse.de> <200202281907.g1SJ7Ul16828@ns.caldera.de>
In-Reply-To: <200202281907.g1SJ7Ul16828@ns.caldera.de>
On Thu, Feb 28, 2002 at 08:07:30PM +0100, Christoph Hellwig wrote:
> - couldn't you make inc_nr_active_pages/dec_nr_active_pages/
> inc_nr_inactive_pages/dec_nr_inactive_pages inlines?
> The current macro abuse isn't nice.
I just wanted to be sure to get the very best compilation (but yes, gcc
should be good enough anyways, so I'm fine to make it an inline instead
of a macro).
> - in mm/memory.c (the 1141 chunk) you introduced a race.
I don't think so, that's a safe and worthwhile optimization (allows
minor swapins while swapcache is under swapout, that's perfectly safe
and it helps a lot). There's no race there.
Andrea
prev parent reply other threads:[~2002-03-02 1:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-02-28 16:46 Andrea Arcangeli
2002-02-28 15:41 ` Marcelo Tosatti
2002-02-28 19:07 ` Christoph Hellwig
2002-03-02 1:23 ` Andrea Arcangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020302022301.B4431@inspiron.random \
--to=andrea@suse.de \
--cc=andrewm@uow.edu.au \
--cc=hch@ns.caldera.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®