Re: [BUG][PATCH] boot failure Re: Linux 2.2.21pre4

Re: [BUG][PATCH] boot failure Re: Linux 2.2.21pre4

[Mikael Pettersson]

Barry K. Nathan wrote:
>Reversing the following change to bluesmoke.c lets this computer boot
>again like it does with 2.2.21-pre3. The computer in question has a 533MHz
>Intel Celeron (the Pentium II-based kind).
>
>-Barry K. Nathan <barryn@pobox.com>
>
>diff -ruN linux-2.2.21-pre3/arch/i386/kernel/bluesmoke.c linux-2.2.21-pre4/arch/i386/kernel/bluesmoke.c
>--- linux-2.2.21-pre3/arch/i386/kernel/bluesmoke.c	Sun Mar  3 23:20:11 2002
>+++ linux-2.2.21-pre4/arch/i386/kernel/bluesmoke.c	Sat Mar  9 03:58:57 2002
>@@ -165,7 +164,7 @@
> 	if(l&(1<<8))
> 		wrmsr(0x17b, 0xffffffff, 0xffffffff);
> 	banks = l&0xff;
>-	for(i=1;i<banks;i++)
>+	for(i=0;i<banks;i++)
> 	{
> 		wrmsr(0x400+4*i, 0xffffffff, 0xffffffff); 
> 	}

Same here. s/i=0/i=1/ i the for() and my PII boots again.

/Mikael

[BUG][PATCH] boot failure Re: Linux 2.2.21pre4

[Barry K. Nathan]

> Please save any 2.2 updates for 2.2.22pre from now on unless they are
> clear bug fixes. I hope to do a 2.2.21rc1 next
> 
> 2.2.21pre4
[snip]
> o	Fix MCE address reporting order, fix oops with	(Dave Jones)
> 	newer gcc due to bad asm constraints

Hmmm... I have a computer here that freezes at this point in the boot
process with 2.2.21-pre4:

...
CPU: L2 cache: 128K
Intel machine check architecture supported.

Reversing the following change to bluesmoke.c lets this computer boot
again like it does with 2.2.21-pre3. The computer in question has a 533MHz
Intel Celeron (the Pentium II-based kind).

-Barry K. Nathan <barryn@pobox.com>

diff -ruN linux-2.2.21-pre3/arch/i386/kernel/bluesmoke.c linux-2.2.21-pre4/arch/i386/kernel/bluesmoke.c
--- linux-2.2.21-pre3/arch/i386/kernel/bluesmoke.c	Sun Mar  3 23:20:11 2002
+++ linux-2.2.21-pre4/arch/i386/kernel/bluesmoke.c	Sat Mar  9 03:58:57 2002
@@ -165,7 +164,7 @@
 	if(l&(1<<8))
 		wrmsr(0x17b, 0xffffffff, 0xffffffff);
 	banks = l&0xff;
-	for(i=1;i<banks;i++)
+	for(i=0;i<banks;i++)
 	{
 		wrmsr(0x400+4*i, 0xffffffff, 0xffffffff); 
 	}