From: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
To: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: Linux 2.4.19-pre3-ac5
Date: Fri, 22 Mar 2002 09:56:28 +0100 [thread overview]
Message-ID: <20020322095628.A28751@wohnheim.fh-wedel.de> (raw)
In-Reply-To: <00e401c1d13e$d5d92580$02c8a8c0@kroptech.com>
Hi!
> kernel BUG at ide-cd.c:790!
> invalid operand: 0000
The code appears to be too paranoid here. In case noone else submitted
a patch yet, here is mine.
Apply with patch -p0.
Jörn
--
Measure. Don't tune for speed until you've measured, and even then
don't unless one part of the code overwhelms the rest.
-- Rob Pike
--- drivers/ide/ide-cd.c Fri Mar 22 09:48:42 2002
+++ drivers/ide/ide-cd.c.new Fri Mar 22 09:52:59 2002
@@ -786,9 +786,6 @@
return startstop;
}
- if (HWGROUP(drive)->handler == NULL) /* paranoia check */
- BUG();
-
/* Arm the interrupt handler. */
ide_set_handler (drive, handler, timeout, cdrom_timer_expiry);
next prev parent reply other threads:[~2002-03-22 8:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-21 23:08 rwhron
2002-03-22 1:13 ` Adam Kropelin
2002-03-22 8:56 ` Jörn Engel [this message]
2002-03-22 8:56 ` Zwane Mwaikambo
2002-03-22 9:14 ` [PATCH] ide-cd-typo.patch (Re: Linux 2.4.19-pre3-ac5) Andre Hedrick
2002-03-22 9:20 ` Jörn Engel
[not found] <20020322101520.A16964@wohnheim.fh-wedel.de>
2002-03-22 9:12 ` Linux 2.4.19-pre3-ac5 Zwane Mwaikambo
2002-03-22 9:30 ` Andre Hedrick
2002-03-22 9:33 ` Zwane Mwaikambo
-- strict thread matches above, loose matches on Subject: below --
2002-03-21 14:45 Alan Cox
2002-03-22 0:27 ` Trond Myklebust
2002-03-22 0:45 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020322095628.A28751@wohnheim.fh-wedel.de \
--to=joern@wohnheim.fh-wedel.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®