[PATCH] ide-cd-typo.patch (Re: Linux 2.4.19-pre3-ac5)

[Andre Hedrick <andre@linux-ide.org>]

[-- Attachment #1: Type: text/plain, Size: 1202 bytes --]


Goto Line 790 in ide-cd.c and manually edit it.

But since you asked for a patch here is one.

Cheers,

Andre Hedrick
LAD Storage Consulting Group


On Fri, 22 Mar 2002, Jörn Engel wrote:

> Hi!
> 
> > kernel BUG at ide-cd.c:790!
> > invalid operand: 0000
> 
> The code appears to be too paranoid here. In case noone else submitted
> a patch yet, here is mine.
> Apply with patch -p0.
> 
> Jörn
> 
> -- 
> Measure. Don't tune for speed until you've measured, and even then
> don't unless one part of the code overwhelms the rest.
> -- Rob Pike
> 
> --- drivers/ide/ide-cd.c	Fri Mar 22 09:48:42 2002
> +++ drivers/ide/ide-cd.c.new	Fri Mar 22 09:52:59 2002
> @@ -786,9 +786,6 @@
>  			return startstop;
>  	}
>  
> -	if (HWGROUP(drive)->handler == NULL)	/* paranoia check */
> -		BUG();
> -
>  	/* Arm the interrupt handler. */
>  	ide_set_handler (drive, handler, timeout, cdrom_timer_expiry);
>  
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

[-- Attachment #2: Type: text/plain, Size: 343 bytes --]

--- linux/drivers/ide/ide-cd.c.orig	Fri Mar 22 01:11:51 2002
+++ linux/drivers/ide/ide-cd.c	Fri Mar 22 01:11:18 2002
@@ -786,7 +786,7 @@
 			return startstop;
 	}
 
-	if (HWGROUP(drive)->handler == NULL)	/* paranoia check */
+	if (HWGROUP(drive)->handler != NULL)	/* paranoia check */
 		BUG();
 
 	/* Arm the interrupt handler. */