From: Francois Romieu <romieu@cogenit.fr>
To: Maksim Krasnyanskiy <maxk@qualcomm.com>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
marcelo Tosatti <marcelo@conectiva.com.br>,
Alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] Updated ATM patch for 2.4.19-pre4
Date: Sat, 23 Mar 2002 22:10:58 +0100 [thread overview]
Message-ID: <20020323221058.B15111@fafner.intra.cogenit.fr> (raw)
In-Reply-To: <5.1.0.14.2.20020322170653.0337b970@mail1.qualcomm.com>
Maksim Krasnyanskiy <maxk@qualcomm.com> :
[...]
> I updated ATM patch for 2.4.19-pre4. It includes couple of fixes that I
> missed in my first patch
> and includes ATM Ethernet bridging support (RFC2684) implemented by Marcell
> GAL.
> It is rather big for email. Here is the URL:
> http://bluez.sourceforge.net/patches/atm.patch-2.4.19-pre4.gz
1 - It won't compile with CONFIG_ATM_BR2684_IPFILTER=y (see error message
below). Suggested fix:
ed net/atm/br2684.c <<EOF
17a
#include <linux/ip.h>
.
wq
EOF
-> Error message:
make[2]: Entering directory `/tmp/romieu/kernel/linux-2.4.19-pre4/net/atm'
kgcc -D__KERNEL__ -I/tmp/romieu/kernel/linux-2.4.19-pre4/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing
-fno-common -pipe -march=i686 -DMODULE -DKBUILD_BASENAME=br2684 -c -o
br2684.o br2684.c
br2684.c: In function `packet_fails_filter':
br2684.c:378: dereferencing pointer to incomplete type
make[2]: *** [br2684.o] Error 1
make[2]: Leaving directory `/tmp/romieu/kernel/linux-2.4.19-pre4/net/atm'
make[1]: *** [_modsubdir_atm] Error 2
make[1]: Leaving directory `/tmp/romieu/kernel/linux-2.4.19-pre4/net'
make: *** [_mod_net] Error 2
2 - As the patch does many things, splitting it in parts would be nice imho.
3 - I have on my TODO a 'please ifconfig down before killing br2684ctl' BUG
that Marcell Gal told me a few months ago (*spleen*). Did someone take care
of it ?
--
Ueimor
next prev parent reply other threads:[~2002-03-23 21:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-23 1:15 Maksim Krasnyanskiy
2002-03-23 1:54 ` Mr. James W. Laferriere
2002-03-23 1:58 ` Mr. James W. Laferriere
2002-03-23 21:10 ` Francois Romieu [this message]
2002-03-24 21:06 ` Francois Romieu
2002-03-25 21:53 ` [Linux-ATM-General] " Maksim Krasnyanskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020323221058.B15111@fafner.intra.cogenit.fr \
--to=romieu@cogenit.fr \
--cc=Alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=maxk@qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®