From: Maksim Krasnyanskiy <maxk@qualcomm.com>
To: Francois Romieu <romieu@cogenit.fr>
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
marcelo Tosatti <marcelo@conectiva.com.br>,
Alan@lxorguk.ukuu.org.uk, cell@sch.bme.hu,
linux-atm-general@lists.sourceforge.net
Subject: Re: [Linux-ATM-General] Re: [PATCH] Updated ATM patch for 2.4.19-pre4
Date: Mon, 25 Mar 2002 13:53:39 -0800 [thread overview]
Message-ID: <5.1.0.14.2.20020325134840.035020e0@mail1.qualcomm.com> (raw)
In-Reply-To: <20020324220622.A1054@fafner.intra.cogenit.fr>
>Comments welcome.
Looks ok to me.
> static inline struct br2684_dev *BRPRIV(const struct net_device *net_dev)
> {
>- return (struct br2684_dev *) ((char *) (net_dev) -
>- (unsigned long) (&((struct br2684_dev *) 0)->net_dev));
>+ return list_entry(net_dev, struct br2684_dev, net_dev);
> }
Although list_entry does the same thing it's inappropriate here. People
will be confused.
Max
prev parent reply other threads:[~2002-03-25 21:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-23 1:15 Maksim Krasnyanskiy
2002-03-23 1:54 ` Mr. James W. Laferriere
2002-03-23 1:58 ` Mr. James W. Laferriere
2002-03-23 21:10 ` Francois Romieu
2002-03-24 21:06 ` Francois Romieu
2002-03-25 21:53 ` Maksim Krasnyanskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5.1.0.14.2.20020325134840.035020e0@mail1.qualcomm.com \
--to=maxk@qualcomm.com \
--cc=Alan@lxorguk.ukuu.org.uk \
--cc=cell@sch.bme.hu \
--cc=linux-atm-general@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=romieu@cogenit.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®