* Re: [PATCH] 2.5.18 : drivers/pci/pool.c minor printk fix
2002-05-27 1:06 [PATCH] 2.5.18 : drivers/pci/pool.c minor printk fix Frank Davis
@ 2002-05-25 13:18 ` Arnaldo Carvalho de Melo
2002-05-27 10:11 ` Alan Cox
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2002-05-25 13:18 UTC (permalink / raw)
To: Frank Davis; +Cc: linux-kernel, torvalds
Em Sun, May 26, 2002 at 09:06:08PM -0400, Frank Davis escreveu:
> The following patch addresses a compile warning. printk saw the "," as
> an argument, which it shouldn't.
> Regards,
> Frank
>
> --- drivers/pci/pool.c.old Thu May 9 19:01:28 2002
> +++ drivers/pci/pool.c Sun May 26 20:55:42 2002
> @@ -309,7 +309,7 @@
> return;
> }
> if (page->bitmap [map] & (1UL << block)) {
> - printk (KERN_ERR "pci_pool_free %s/%s, dma %x already free\n",
> + printk (KERN_ERR "pci_pool_free %s/%s dma %x already free\n",
> pool->dev ? pool->dev->slot_name : NULL,
> pool->name, dma);
> return;
OUCH, so you should fix printk instead ;)
Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] 2.5.18 : drivers/pci/pool.c minor printk fix
@ 2002-05-27 1:06 Frank Davis
2002-05-25 13:18 ` Arnaldo Carvalho de Melo
2002-05-27 10:11 ` Alan Cox
0 siblings, 2 replies; 3+ messages in thread
From: Frank Davis @ 2002-05-27 1:06 UTC (permalink / raw)
To: linux-kernel; +Cc: fdavis, torvalds
Hello,
The following patch addresses a compile warning. printk saw the "," as
an argument, which it shouldn't.
Regards,
Frank
--- drivers/pci/pool.c.old Thu May 9 19:01:28 2002
+++ drivers/pci/pool.c Sun May 26 20:55:42 2002
@@ -309,7 +309,7 @@
return;
}
if (page->bitmap [map] & (1UL << block)) {
- printk (KERN_ERR "pci_pool_free %s/%s, dma %x already free\n",
+ printk (KERN_ERR "pci_pool_free %s/%s dma %x already free\n",
pool->dev ? pool->dev->slot_name : NULL,
pool->name, dma);
return;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] 2.5.18 : drivers/pci/pool.c minor printk fix
2002-05-27 1:06 [PATCH] 2.5.18 : drivers/pci/pool.c minor printk fix Frank Davis
2002-05-25 13:18 ` Arnaldo Carvalho de Melo
@ 2002-05-27 10:11 ` Alan Cox
1 sibling, 0 replies; 3+ messages in thread
From: Alan Cox @ 2002-05-27 10:11 UTC (permalink / raw)
To: Frank Davis; +Cc: linux-kernel, torvalds
On Mon, 2002-05-27 at 02:06, Frank Davis wrote:
> Hello,
> The following patch addresses a compile warning. printk saw the "," as
> an argument, which it shouldn't.
So fix printk or whatever actually got confused not the symptom
> if (page->bitmap [map] & (1UL << block)) {
> - printk (KERN_ERR "pci_pool_free %s/%s, dma %x already free\n",
> + printk (KERN_ERR "pci_pool_free %s/%s dma %x already free\n",
> pool->dev ? pool->dev->slot_name : NULL,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-05-27 9:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-05-27 1:06 [PATCH] 2.5.18 : drivers/pci/pool.c minor printk fix Frank Davis
2002-05-25 13:18 ` Arnaldo Carvalho de Melo
2002-05-27 10:11 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®