[2.5 patch] drivers/hotplug/cpqphp.h must include tqueue.h

[2.5 patch] drivers/hotplug/cpqphp.h must include tqueue.h

[Adrian Bunk]

Hi,

another tqueue.h compile problem: It's needed in drivers/hotplug/cpqphp.h,
otherwise compilation fails:

<--  snip  -->

...
  gcc -Wp,-MD,./.cpqphp_core.o.d -D__KERNEL__
-I/home/bunk/linux/kernel-2.5/linux-2.5.23/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2
-fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2
-march=k6 -nostdinc -iwithprefix include    -DKBUILD_BASENAME=cpqphp_core   -c -o
cpqphp_core.o cpqphp_core.c
In file included from cpqphp_core.c:39:
cpqphp.h:322: field `int_task_event' has incomplete type
make[2]: *** [cpqphp_core.o] Error 1
make[2]: Leaving directory
`/home/bunk/linux/kernel-2.5/linux-2.5.23/drivers/hotplug'

<--  snip  -->



--- drivers/hotplug/cpqphp.h.old	Wed Jun 19 23:19:02 2002
+++ drivers/hotplug/cpqphp.h	Wed Jun 19 23:20:15 2002
@@ -29,6 +29,7 @@
 #define _CPQPHP_H

 #include "pci_hotplug.h"
+#include <linux/tqueue.h>
 #include <asm/io.h>		/* for read? and write? functions */


cu
Adrian

-- 

You only think this is a free country. Like the US the UK spends a lot of
time explaining its a free country because its a police state.
								Alan Cox

Re: [2.5 patch] drivers/hotplug/cpqphp.h must include tqueue.h

[Greg KH]

On Wed, Jun 19, 2002 at 11:31:50PM +0200, Adrian Bunk wrote:
> Hi,
> 
> another tqueue.h compile problem: It's needed in drivers/hotplug/cpqphp.h,
> otherwise compilation fails:

Thanks, but I prefer this fix:

greg k-h


diff -Nru a/drivers/hotplug/cpqphp_core.c b/drivers/hotplug/cpqphp_core.c
--- a/drivers/hotplug/cpqphp_core.c	Wed Jun 19 14:38:54 2002
+++ b/drivers/hotplug/cpqphp_core.c	Wed Jun 19 14:38:54 2002
@@ -33,6 +33,7 @@
 #include <linux/proc_fs.h>
 #include <linux/miscdevice.h>
 #include <linux/slab.h>
+#include <linux/tqueue.h>
 #include <linux/pci.h>
 #include <linux/init.h>
 #include <asm/uaccess.h>
diff -Nru a/drivers/hotplug/cpqphp_ctrl.c b/drivers/hotplug/cpqphp_ctrl.c
--- a/drivers/hotplug/cpqphp_ctrl.c	Wed Jun 19 14:38:54 2002
+++ b/drivers/hotplug/cpqphp_ctrl.c	Wed Jun 19 14:38:54 2002
@@ -31,6 +31,7 @@
 #include <linux/kernel.h>
 #include <linux/types.h>
 #include <linux/slab.h>
+#include <linux/tqueue.h>
 #include <linux/interrupt.h>
 #include <linux/delay.h>
 #include <linux/wait.h>
diff -Nru a/drivers/hotplug/cpqphp_nvram.c b/drivers/hotplug/cpqphp_nvram.c
--- a/drivers/hotplug/cpqphp_nvram.c	Wed Jun 19 14:38:54 2002
+++ b/drivers/hotplug/cpqphp_nvram.c	Wed Jun 19 14:38:54 2002
@@ -33,6 +33,7 @@
 #include <linux/proc_fs.h>
 #include <linux/miscdevice.h>
 #include <linux/slab.h>
+#include <linux/tqueue.h>
 #include <linux/pci.h>
 #include <linux/init.h>
 #include <asm/uaccess.h>
diff -Nru a/drivers/hotplug/cpqphp_pci.c b/drivers/hotplug/cpqphp_pci.c
--- a/drivers/hotplug/cpqphp_pci.c	Wed Jun 19 14:38:54 2002
+++ b/drivers/hotplug/cpqphp_pci.c	Wed Jun 19 14:38:54 2002
@@ -31,6 +31,7 @@
 #include <linux/kernel.h>
 #include <linux/types.h>
 #include <linux/slab.h>
+#include <linux/tqueue.h>
 #include <linux/proc_fs.h>
 #include <linux/pci.h>
 #include "cpqphp.h"
diff -Nru a/drivers/hotplug/cpqphp_proc.c b/drivers/hotplug/cpqphp_proc.c
--- a/drivers/hotplug/cpqphp_proc.c	Wed Jun 19 14:38:54 2002
+++ b/drivers/hotplug/cpqphp_proc.c	Wed Jun 19 14:38:54 2002
@@ -31,6 +31,7 @@
 #include <linux/kernel.h>
 #include <linux/types.h>
 #include <linux/proc_fs.h>
+#include <linux/tqueue.h>
 #include <linux/pci.h>
 #include "cpqphp.h"