mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andries Brouwer <aebr@win.tue.nl>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: hd_geometry question.
Date: Mon, 1 Jul 2002 21:58:32 +0200	[thread overview]
Message-ID: <20020701195832.GA21495@win.tue.nl> (raw)
In-Reply-To: <200207011802.07212.schwidefsky@de.ibm.com>

On Mon, Jul 01, 2002 at 06:02:07PM +0200, Martin Schwidefsky wrote:

> I have a question about the start field in the hd_geometry structure. We used
> 
> 	geo->start = device->major_info->gendisk.part[MINOR(kdev)].start_sect
> 		>> device->sizes.s2b_shift;
> 
> in the old dasd driver but now we use
> 
> 	geo.start = get_start_sect(kdev);
> 
> to set the start field. One variant is wrong because the start sector differ if
> the block size is not 512 byte. The first variant calculates the start sector
> based on physical blocks (e.g. with 4096 bytes instead of 512 bytes). The
> second variant calulcates a "soft" start sector based on logical 512 byte
> blocks. Whats correct, first or second variant ?? I tend to favor the first
> variant because struct hd_geometry describes the physical geometry
> (number of heads, sectors, cylinders and start sector) but I am not 100%
> sure about it.

About a partition one wants to know start and length.
About a full disk one wants to know size, and perhaps a (fake) geometry.

The vital partition data cannot depend on obscure hardware info.
So, the units used must be well-known. Earlier, everything was in
512-byte sectors, but there are a few places where that is inconvenient
or unnatural, and now that one has more than 2^32 sectors and 64 bits
are needed anyway, things are measured in bytes.

That the start field comes with the HDIO_GETGEO ioctl and the size with
the BLKGETSIZE ioctl is due to history. Both are given in 512-byte sectors.
BLKGETSIZE64 gives bytes.

Andries


  parent reply	other threads:[~2002-07-01 19:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-01 16:02 Martin Schwidefsky
2002-07-01 19:19 ` Andre Hedrick
2002-07-01 19:58 ` Andries Brouwer [this message]
2002-07-02  9:16 Martin Schwidefsky
2002-07-02 10:50 ` jw schultz
2002-07-03  0:20 ` Andries Brouwer
2002-07-03 23:48   ` Roman Zippel
2002-07-04  9:09     ` Andries Brouwer
2002-07-04 22:15       ` Andre Hedrick
2002-07-08 18:55     ` Alan Cox
2002-07-03  8:13 Martin Schwidefsky
2002-07-03  9:37 ` Andries Brouwer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020701195832.GA21495@win.tue.nl \
    --to=aebr@win.tue.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®