2.4.19-rc1 doesn't link

2.4.19-rc1 doesn't link

[Richard Gooch]

  Hi, all. Looks like initrd handling has been broken again:
init/do_mounts.o: In function `rd_load_image':
init/do_mounts.o(.text.init+0x941): undefined reference to `change_floppy'
init/do_mounts.o: In function `rd_load_disk':
init/do_mounts.o(.text.init+0xa9b): undefined reference to `change_floppy'
make: *** [vmlinux] Error 1

This is the config option combination that exposed the bug:
CONFIG_BLK_DEV_RAM=y
# CONFIG_BLK_DEV_INITRD is not set

				Regards,

					Richard....
Permanent: rgooch@atnf.csiro.au
Current:   rgooch@ras.ucalgary.ca

Re: 2.4.19-rc1 doesn't link

[Thunder from the hill]

Hi,

On Mon, 8 Jul 2002, Richard Gooch wrote:
> init/do_mounts.o: In function `rd_load_image':
> init/do_mounts.o(.text.init+0x941): undefined reference to `change_floppy'
> init/do_mounts.o: In function `rd_load_disk':
> init/do_mounts.o(.text.init+0xa9b): undefined reference to `change_floppy'
> make: *** [vmlinux] Error 1

Strange thing. All three are #ifdef CONFIG_BLK_DEV_RAM, so if you enable 
BLK_DEV_RAM, you get all three. Do you have CONFIG_BLK_DEV_FD enabled?

							Regards,
							Thunder
-- 
(Use http://www.ebb.org/ungeek if you can't decode)
------BEGIN GEEK CODE BLOCK------
Version: 3.12
GCS/E/G/S/AT d- s++:-- a? C++$ ULAVHI++++$ P++$ L++++(+++++)$ E W-$
N--- o?  K? w-- O- M V$ PS+ PE- Y- PGP+ t+ 5+ X+ R- !tv b++ DI? !D G
e++++ h* r--- y- 
------END GEEK CODE BLOCK------

Re: 2.4.19-rc1 doesn't link

[J.A. Magallon]

On 2002.07.09 Thunder from the hill wrote:
>Hi,
>
>On Mon, 8 Jul 2002, Richard Gooch wrote:
>> init/do_mounts.o: In function `rd_load_image':
>> init/do_mounts.o(.text.init+0x941): undefined reference to `change_floppy'
>> init/do_mounts.o: In function `rd_load_disk':
>> init/do_mounts.o(.text.init+0xa9b): undefined reference to `change_floppy'
>> make: *** [vmlinux] Error 1
>
>Strange thing. All three are #ifdef CONFIG_BLK_DEV_RAM, so if you enable 
>BLK_DEV_RAM, you get all three. Do you have CONFIG_BLK_DEV_FD enabled?
>

Known bug. Try:

http://giga.cps.unizar.es/~magallon/linux/kernel/2.4.19-rc1-jam1/02-blk-dev-ram.bz2

-- 
J.A. Magallon             \   Software is like sex: It's better when it's free
mailto:jamagallon@able.es  \                    -- Linus Torvalds, FSF T-shirt
Linux werewolf 2.4.19-rc1-jam1, Mandrake Linux 8.3 (Cooker) for i586
gcc (GCC) 3.1.1 (Mandrake Linux 8.3 3.1.1-0.7mdk)

Re: 2.4.19-rc1 doesn't link

[Paul Mackerras]

Richard Gooch writes:

>   Hi, all. Looks like initrd handling has been broken again:
> init/do_mounts.o: In function `rd_load_image':
> init/do_mounts.o(.text.init+0x941): undefined reference to `change_floppy'
> init/do_mounts.o: In function `rd_load_disk':
> init/do_mounts.o(.text.init+0xa9b): undefined reference to `change_floppy'
> make: *** [vmlinux] Error 1
> 
> This is the config option combination that exposed the bug:
> CONFIG_BLK_DEV_RAM=y
> # CONFIG_BLK_DEV_INITRD is not set

This should fix it...

Paul.

diff -urN linux-2.4.19-rc1/init/do_mounts.c pmac/init/do_mounts.c
--- linux-2.4.19-rc1/init/do_mounts.c	Tue Jun 25 01:23:40 2002
+++ pmac/init/do_mounts.c	Mon Jul  8 22:21:04 2002
@@ -378,7 +378,7 @@
 	return sys_symlink(path + n + 5, name);
 }
 
-#if defined(CONFIG_BLOCK_DEV_RAM) || defined(CONFIG_BLK_DEV_FD)
+#if defined(CONFIG_BLK_DEV_RAM) || defined(CONFIG_BLK_DEV_FD)
 static void __init change_floppy(char *fmt, ...)
 {
 	struct termios termios;