From: Francois Romieu <romieu@cogenit.fr>
To: support <support@promise.com.tw>
Cc: Hank <hanky@promise.com.tw>,
linux-kernel@vger.kernel.org, marcelo@conectiva.com.br,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] 2.4.19-rc2-ac2 pdc202xx.c update
Date: Mon, 22 Jul 2002 08:35:48 +0200 [thread overview]
Message-ID: <20020722083548.A27973@fafner.intra.cogenit.fr> (raw)
In-Reply-To: <01ee01c2312e$22976900$47cba8c0@promise.com.tw>; from support@promise.com.tw on Mon, Jul 22, 2002 at 11:16:04AM +0800
support <support@promise.com.tw> :
[...]
> We don't occur Oops you said, Please check your patch rule again.
There's a side effect with your macro. Let's expand it:
+#define set_2regs(a, b) \
+ OUT_BYTE((a + adj), indexreg); \
+ OUT_BYTE(b, datareg);
[...]
+ if (speed == XFER_UDMA_2)
+ set_2regs(thold, (IN_BYTE(datareg) & 0x7f));
if (speed == XFER_UDMA_2)
OUT_BYTE((thold + adj), indexreg);
OUT_BYTE((IN_BYTE(datareg) & 0x7f), datareg);
Do you see the problem ?
--
Ueimor
next prev parent reply other threads:[~2002-07-22 6:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <01b801c22f0b$c02cc360$47cba8c0@promise.com.tw>
2002-07-22 3:16 ` support
2002-07-22 6:35 ` Francois Romieu [this message]
2002-07-23 1:05 ` support
2002-07-23 7:19 ` Francois Romieu
2002-07-23 17:08 ` Michal Jaegermann
2002-07-23 10:49 Mikael Pettersson
-- strict thread matches above, loose matches on Subject: below --
2002-07-19 9:09 support
2002-07-19 9:52 ` Giro
2002-07-19 9:56 ` Giro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020722083548.A27973@fafner.intra.cogenit.fr \
--to=romieu@cogenit.fr \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=hanky@promise.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=support@promise.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®