Re: [PATCH] 2.4.19-rc2-ac2 pdc202xx.c update

[Francois Romieu <romieu@cogenit.fr>]

support <support@promise.com.tw> :
> We think there is no problems, Acturally it is
> 
> if (speed == XFER_UDMA_2) {
>         OUT_BYTE((thold + adj), indexreg);
>         OUT_BYTE((IN_BYTE(datareg) & 0x7f), datareg);
> }
> 
> So,
> if (speed == XFER_UDMA_2)
>         set_2regs(thold, (IN_BYTE(datareg) & 0x7f));

set_2regs() is a macro. Macro have side effects.

Before the change, assuming speed != XFER_UDMA_2

if (speed == XFER_UDMA_2) {
	OUT_BYTE((thold + adj), indexreg); 		<- not executed
	OUT_BYTE((IN_BYTE(datareg) & 0x7f), datareg);	<- not executed
}

-> the block isn't executed

After the change, the code is:

if (speed == XFER_UDMA_2)
        OUT_BYTE((thold + adj), indexreg);              <- not executed
        OUT_BYTE((IN_BYTE(datareg) & 0x7f), datareg);   <- executed, damn it !

-> only the first statement of the macro is executed.

Put a pair of {} after the "if", a "do {...} while (0)" in the macro
declaration. Please, please, think about it a few minutes.

-- 
Ueimor