From: Richard Gooch <rgooch@ras.ucalgary.ca>
To: Alexander Viro <viro@math.psu.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Rusty's module talk at the Kernel Summit
Date: Mon, 22 Jul 2002 22:37:09 -0600 [thread overview]
Message-ID: <200207230437.g6N4b9S23747@vindaloo.ras.ucalgary.ca> (raw)
In-Reply-To: <Pine.GSO.4.21.0207221216240.6045-100000@weyl.math.psu.edu>
Alexander Viro writes:
> On Thu, 18 Jul 2002, Richard Gooch wrote:
> > Can you point to specific problems with the current devfs code?
>
> Sigh... How many do you want? Look, couple of days ago I'd done
> the following: picked a random number in range 1..`wc -l
> fs/devfs/base.c`, checked what function it was in (devfs_readdir())
> and spent less than two minutes reading it before finding a bug (a
> leak - there's a couple of paths that grab an entry and return
> without releasing it).
Ouch. I see what you're referring to: if *readdir() fails, the devfs
entry is not cleaned up. I've fixed that in my tree, as well as made
the (minor) optimisation of avoiding re-taking the parent lock on
error.
> So tell me how many times I should repeat that exercise and while
> you are at it, tell me what stops you from doing the same.
Well, I *have* looked at it. But after a while, it gets harder to spot
bugs because it gets stale. That's why a fresh pair of eyes is so
valuable.
> Because you know, reading devfs code is something I'd rather avoid -
> it's not my idea of fun reading. IF it will stop you from claiming
> "Al hadn't done public whippings lately, so devfs is bug-free" for a
> couple of months - by all means, tell how many bugs do I need to
> find and report to shut you up for a while.
How about just letting me know about all the bugs you find? I would
find that helpful.
> Richard, devfs code is _ripe_ with bugs; you can't spit into it
> without hitting one. And excuse me, but when finding one is a
> matter of two minutes I can't believe that you are incapable of
> doing that on your own. It used to be annoying; by now it's beyond
> annoying - it's ridiculous.
I find it hard to believe that the code is ripe with bugs. While there
may be one or two bugs still lurking, the code overall looks to be in
pretty good shape. All the work I put into adding the locking and
refcounting has paid off. Is it just bad luck that you randomly looked
at devfs_readdir() and found one of the (hopefully few) bugs? Or have
you actually seen a large number of bugs that justifies the "ripe"
label?
I could just go and read the code periodically, looking for bugs, but
I'd quickly burn out, and the incremental benefit would likely be
minor. A fresh pair of eyeballs is much better. And that is supposed
to be the power of open source.
Regards,
Richard....
Permanent: rgooch@atnf.csiro.au
Current: rgooch@ras.ucalgary.ca
next prev parent reply other threads:[~2002-07-23 4:34 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-04 17:24 Adam J. Richter
2002-07-11 2:48 ` Rusty Russell
2002-07-11 2:45 ` David S. Miller
2002-07-11 3:30 ` Alexander Viro
2002-07-11 5:13 ` Rusty Russell
2002-07-11 6:37 ` Alexander Viro
2002-07-11 7:14 ` Rusty Russell
2002-07-11 10:54 ` Daniel Phillips
2002-07-11 17:37 ` Roman Zippel
2002-07-11 18:01 ` Thunder from the hill
2002-07-11 18:50 ` Daniel Phillips
2002-07-17 18:16 ` bill davidsen
2002-07-17 19:35 ` Thunder from the hill
2002-07-11 18:28 ` Daniel Phillips
2002-07-11 19:48 ` Roman Zippel
2002-07-11 20:29 ` Daniel Phillips
2002-07-11 23:37 ` Alexander Viro
2002-07-12 1:54 ` Daniel Phillips
2002-07-12 3:53 ` Rusty Russell
2002-07-12 6:49 ` Kai Henningsen
2002-07-12 11:30 ` Roman Zippel
2002-07-12 0:00 ` Rusty Russell
2002-07-12 6:57 ` Kai Henningsen
2002-07-19 0:19 ` Richard Gooch
2002-07-22 16:29 ` Alexander Viro
2002-07-23 4:37 ` Richard Gooch [this message]
2002-07-11 4:02 ` Cort Dougan
2002-07-11 4:19 ` Arnaldo Carvalho de Melo
2002-07-11 4:46 ` Cort Dougan
2002-07-11 2:55 ` Arnaldo Carvalho de Melo
2002-07-11 3:01 ` Arnaldo Carvalho de Melo
2002-07-11 5:16 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2002-07-11 5:44 Adam J. Richter
2002-07-11 5:07 Adam J. Richter
2002-07-03 15:53 Adam J. Richter
2002-07-03 17:07 ` Hugh Dickins
2002-07-03 18:46 ` Oliver Neukum
2002-07-03 23:25 ` Keith Owens
2002-07-03 23:09 ` Keith Owens
2002-07-03 7:31 Adam J. Richter
2002-07-03 8:54 ` Rogier Wolff
2002-07-03 12:27 ` Keith Owens
2002-07-03 14:10 ` Keith Owens
2002-07-01 17:20 Adam J. Richter
2002-07-01 16:12 Adam J. Richter
2002-07-01 17:02 ` jlnance
2002-07-03 5:01 ` Keith Owens
2002-07-01 8:45 Keith Owens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200207230437.g6N4b9S23747@vindaloo.ras.ucalgary.ca \
--to=rgooch@ras.ucalgary.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®