From: "Mirko Dölle" <mdoelle@linux-user.de>
To: alan@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] 2.4.19-rc3, i810_audio: ignoring ready status of ICH for i845G chipset / Epox mainboard
Date: Sun, 28 Jul 2002 05:00:06 +0200 (CEST) [thread overview]
Message-ID: <20020728030014.B250015C97@mail.linux-new-media.de> (raw)
Hello,
this patch for Kernel 2.4.19-rc3 removes the "break" that aborted the module
init of i810_audio.o in case of "not ready" status before probing (line
2656-2663).
On my Epox 4G4A+ mainboard with i845G chipset the ready status was always "0",
so the module could not be loaded. After removing the "break" in line 2663
the module works great: loading, playing serveral MP3s, removing and reloading
were no problem.
Perhaps someone can confirm this so the break could perhaps be removed in the
final Kernel 2.4.19.
diff -ru linux-2.4.19-rc3.orig/drivers/sound/i810_audio.c linux-2.4.19-rc3.patched/drivers/sound/i810_audio.c
--- linux-2.4.19-rc3.orig/drivers/sound/i810_audio.c Sun Jul 28 05:54:54 2002
+++ linux-2.4.19-rc3.patched/drivers/sound/i810_audio.c Sun Jul 28 06:06:06 2002
@@ -2660,7 +2660,10 @@
if (!i810_ac97_exists(card,num_ac97)) {
if(num_ac97 == 0)
printk(KERN_ERR "i810_audio: Primary codec not ready.\n");
- break; /* I think this works, if not ready stop */
+ /* Hack by dg2fer: On my Epox 4G4A+ with i845G we should just */
+ /* continue probing and *not* break. The status is always "not */
+ /* ready" but afterwards it works great. So I removed the break. */
+ /* break; */ /* I think this works, if not ready stop */
}
if ((codec = kmalloc(sizeof(struct ac97_codec), GFP_KERNEL)) == NULL)
With best regards,
Sincerely,
Mirko, dg2fer
reply other threads:[~2002-07-28 2:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020728030014.B250015C97@mail.linux-new-media.de \
--to=mdoelle@linux-user.de \
--cc=alan@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®