mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] 2.4.19-rc3, i810_audio: ignoring ready status of ICH for i845G chipset / Epox mainboard
@ 2002-07-28  3:00 Mirko Dölle
  0 siblings, 0 replies; only message in thread
From: Mirko Dölle @ 2002-07-28  3:00 UTC (permalink / raw)
  To: alan; +Cc: linux-kernel

Hello,

this patch for Kernel 2.4.19-rc3 removes the "break" that aborted the module
init of i810_audio.o in case of "not ready" status before probing (line
2656-2663).
On my Epox 4G4A+ mainboard with i845G chipset the ready status was always "0",
so the module could not be loaded. After removing the "break" in line 2663
the module works great: loading, playing serveral MP3s, removing and reloading
were no problem.

Perhaps someone can confirm this so the break could perhaps be removed in the
final Kernel 2.4.19.



diff -ru linux-2.4.19-rc3.orig/drivers/sound/i810_audio.c linux-2.4.19-rc3.patched/drivers/sound/i810_audio.c
--- linux-2.4.19-rc3.orig/drivers/sound/i810_audio.c	Sun Jul 28 05:54:54 2002
+++ linux-2.4.19-rc3.patched/drivers/sound/i810_audio.c	Sun Jul 28 06:06:06 2002
@@ -2660,7 +2660,10 @@
 		if (!i810_ac97_exists(card,num_ac97)) {
 			if(num_ac97 == 0)
 				printk(KERN_ERR "i810_audio: Primary codec not ready.\n");
-			break; /* I think this works, if not ready stop */
+			/* Hack by dg2fer: On my Epox 4G4A+ with i845G we should just    */
+			/* continue probing and *not* break. The status is always "not   */
+			/* ready" but afterwards it works great. So I removed the break. */
+			/* break; */ /* I think this works, if not ready stop */
 		}

 		if ((codec = kmalloc(sizeof(struct ac97_codec), GFP_KERNEL)) == NULL)



With best regards,
Sincerely,
  Mirko, dg2fer


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2002-07-28  2:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-07-28  3:00 [PATCH] 2.4.19-rc3, i810_audio: ignoring ready status of ICH for i845G chipset / Epox mainboard Mirko Dölle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®