* 2.5.30 ACPI: fixing compilation
@ 2002-08-04 18:58 Pavel Machek
2002-08-04 19:19 ` Thunder from the hill
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2002-08-04 18:58 UTC (permalink / raw)
To: Andrew Grover, ACPI mailing list, kernel list
Hi!
This fixes compilation and is actually right since we can't get SMP
machine suspending, anyway. We'll have to bring all other CPUs down
for suspend in future. Please apply,
Pavel
--- clean/drivers/acpi/system.c Mon Jul 29 20:02:23 2002
+++ linux-swsusp/drivers/acpi/system.c Sun Aug 4 20:57:01 2002
@@ -256,7 +256,7 @@
acpi_status status = AE_ERROR;
unsigned long flags = 0;
- save_flags(flags);
+ local_irq_save(flags);
switch (state)
{
@@ -270,7 +270,7 @@
do_suspend_lowlevel(0);
break;
}
- restore_flags(flags);
+ local_irq_restore(flags);
return status;
}
--
Worst form of spam? Adding advertisment signatures ala sourceforge.net.
What goes next? Inserting advertisment *into* email?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: 2.5.30 ACPI: fixing compilation
2002-08-04 18:58 2.5.30 ACPI: fixing compilation Pavel Machek
@ 2002-08-04 19:19 ` Thunder from the hill
2002-08-04 19:22 ` Pavel Machek
0 siblings, 1 reply; 4+ messages in thread
From: Thunder from the hill @ 2002-08-04 19:19 UTC (permalink / raw)
To: Pavel Machek; +Cc: Andrew Grover, ACPI mailing list, kernel list
Hi,
On Sun, 4 Aug 2002, Pavel Machek wrote:
> This fixes compilation and is actually right since we can't get SMP
> machine suspending, anyway.
Did we make sure that we won't suspend on smp? I can't see where that
happens.
Thunder
--
.-../../-./..-/-..- .-./..-/.-.././.../.-.-.-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.5.30 ACPI: fixing compilation
2002-08-04 19:19 ` Thunder from the hill
@ 2002-08-04 19:22 ` Pavel Machek
2002-08-04 19:38 ` Thunder from the hill
0 siblings, 1 reply; 4+ messages in thread
From: Pavel Machek @ 2002-08-04 19:22 UTC (permalink / raw)
To: Thunder from the hill
Cc: Pavel Machek, Andrew Grover, ACPI mailing list, kernel list
Hi!
> > This fixes compilation and is actually right since we can't get SMP
> > machine suspending, anyway.
>
> Did we make sure that we won't suspend on smp? I can't see where that
> happens.
It was broken before so I left it broken. Second CPU will probably
kill it fast enough not to corrupt data too badly.
Does anyone have S3-capable SMP system?
SWSUSP refuses to work on SMP.
Pavel
--
Casualities in World Trade Center: ~3k dead inside the building,
cryptography in U.S.A. and free speech in Czech Republic.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: 2.5.30 ACPI: fixing compilation
2002-08-04 19:22 ` Pavel Machek
@ 2002-08-04 19:38 ` Thunder from the hill
0 siblings, 0 replies; 4+ messages in thread
From: Thunder from the hill @ 2002-08-04 19:38 UTC (permalink / raw)
To: Pavel Machek
Cc: Thunder from the hill, Andrew Grover, ACPI mailing list, kernel list
Hi,
On Sun, 4 Aug 2002, Pavel Machek wrote:
> It was broken before so I left it broken. Second CPU will probably
> kill it fast enough not to corrupt data too badly.
I meant, depending the code on !CONFIG_SMP.
Thunder
--
.-../../-./..-/-..- .-./..-/.-.././.../.-.-.-
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-08-04 19:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-08-04 18:58 2.5.30 ACPI: fixing compilation Pavel Machek
2002-08-04 19:19 ` Thunder from the hill
2002-08-04 19:22 ` Pavel Machek
2002-08-04 19:38 ` Thunder from the hill
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®