From: Sam Ravnborg <sam@ravnborg.org>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>,
linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>,
martin@dalecki.de
Subject: Re: [PATCH] automatic module_init ordering
Date: Sun, 4 Aug 2002 22:04:17 +0200 [thread overview]
Message-ID: <20020804220417.A8175@mars.ravnborg.org> (raw)
In-Reply-To: <3D4D48A7.6BA919D2@linux-m68k.org>; from zippel@linux-m68k.org on Sun, Aug 04, 2002 at 05:30:47PM +0200
On Sun, Aug 04, 2002 at 05:30:47PM +0200, Roman Zippel wrote:
>
> Could you try the attached patch? It should fix all the mentioned
> problems. Files are now regenerated only if something really changed.
> if_changed needed a fix to correctly save the command line and
> dependencies should be correct now.
Looks good, a few comments remains. We are down to matter of personal taste.
> +builtin_mods := $(addsuffix .builtin_mods,$(sort $(dir $(CORE_FILES) $(LIBS)
$(DRIVERS) $(NETWORKS))))
A verbose comment above this line descibing the whole concept about initcalls
would be nice. Keep it short and informative.
> + @echo 'cmd_$(@F) := $(cmd_gen_initcalls)' > .$(@F).cmd
I would like to see $(notdir and the counterpart $(dir used instead of
$(@F) and $(@D). The latter two are deprecated by make.
See make.info.
This is general for all of kbuild, but since this is new stuff I bring it up.
Sam
next prev parent reply other threads:[~2002-08-04 19:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-01 23:52 Roman Zippel
2002-08-02 3:19 ` Kai Germaschewski
2002-08-02 21:22 ` Sam Ravnborg
2002-08-03 1:17 ` Kai Germaschewski
2002-08-03 22:11 ` Sam Ravnborg
2002-08-04 15:30 ` Roman Zippel
2002-08-04 20:04 ` Sam Ravnborg [this message]
2002-08-04 20:10 ` Sam Ravnborg
2002-08-05 6:13 ` Rusty Russell
2002-08-05 19:05 ` Roman Zippel
2002-08-06 7:28 ` Rusty Russell
2002-08-06 18:57 ` Roman Zippel
2002-08-07 1:05 ` Rusty Russell
2002-08-07 2:28 ` Kai Germaschewski
2002-08-07 10:40 ` Roman Zippel
2002-08-07 11:10 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2002-07-29 23:46 [PATCH] automatic initcalls Rusty Russell
2002-07-30 23:04 ` [PATCH] automatic module_init ordering Roman Zippel
2002-07-31 2:33 ` Kai Germaschewski
2002-07-31 3:26 ` Rusty Russell
2002-07-31 17:06 ` Kai Germaschewski
2002-07-31 23:28 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020804220417.A8175@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=kai@tp1.ruhr-uni-bochum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@dalecki.de \
--cc=rusty@rustcorp.com.au \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®