Re: [PATCH] automatic module_init ordering

[Rusty Russell <rusty@rustcorp.com.au>]

In message <Pine.LNX.4.44.0207302110570.19799-100000@chaos.physics.uiowa.edu> y
ou write:
> - It looks like with your current approach you can't have a ',' or '-' in
>   KBUILD_MODNAME - however, that means that KBUILD_MODNAME is not quite
>   right for passing module parameters for built-in modules on the command
>   line, it would be confusing to pass parameters for ide-cd as 
>   ide_cd.foo=whatever. So that part could use a little more thought.

My PARAM code actually maps - to _ in parameter parsing, for exactly
this reason.  And only a complete idiot would put , in a module name,
so I don't care 8)

> - It's possible that objects are linked into more than one module - I 
>   suppose this shouldn't be a problem, since these objects hopefully
>   don't have a module_init() nor do they export symbols. Not sure if your
>   patch did handle this.

There's one piece of code I know which is linked in three places, and
has a module parameter (net/ipv4/netfilter/ip_conntrack_core.c, linked
into ipfwadm.o ipchains.o and ip_conntrack.o.

As it happens, the configuration doesn't allow more than one to be
built in (they can all be modules though), so it's not actually a
problem even after parameter unification.

Thanks,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.