Patch: linux-2.5.31/include/linux/blkdev.h paranethesis problem in BLK__DEFAULT_QUEUE

Patch: linux-2.5.31/include/linux/blkdev.h paranethesis problem in BLK__DEFAULT_QUEUE

[Adam J. Richter]

[-- Attachment #1: Type: text/plain, Size: 628 bytes --]

Hi Jens,

	The following trivial fix has been in my kernel tree for
ages.  It is need for the C compiler to compile statements like
the following, which I use in my version of loop.c:

	BLK_DEFAULT_QUEUE(MAJOR_NR)->queuedata = NULL;

	Could you please apply it to your tree and forward it to
Linus (or let me know if you'd prefer to handle it some other way).

-- 
Adam J. Richter     __     ______________   575 Oroville Road
adam@yggdrasil.com     \ /                  Milpitas, California 95035
+1 408 309-6081         | g g d r a s i l   United States of America
                         "Free Software For The Rest Of Us."

[-- Attachment #2: blkdev.patch --]
[-- Type: text/plain, Size: 532 bytes --]

--- linux-2.5.31/include/linux/blkdev.h	2002-08-10 18:41:23.000000000 -0700
+++ linux/include/linux/blkdev.h	2002-08-11 00:06:37.000000000 -0700
@@ -272,7 +272,7 @@
  * so as to eliminate the need for each and every block device
  * driver to know about the internal structure of blk_dev[].
  */
-#define BLK_DEFAULT_QUEUE(_MAJOR)  &blk_dev[_MAJOR].request_queue
+#define BLK_DEFAULT_QUEUE(_MAJOR)  (&blk_dev[_MAJOR].request_queue)
 
 extern struct sec_size * blk_sec[MAX_BLKDEV];
 extern struct blk_dev_struct blk_dev[MAX_BLKDEV];

Re: Patch: linux-2.5.31/include/linux/blkdev.h paranethesis problem in BLK__DEFAULT_QUEUE

[Jens Axboe]

On Sun, Aug 11 2002, Adam J. Richter wrote:
> Hi Jens,
> 
> 	The following trivial fix has been in my kernel tree for
> ages.  It is need for the C compiler to compile statements like
> the following, which I use in my version of loop.c:
> 
> 	BLK_DEFAULT_QUEUE(MAJOR_NR)->queuedata = NULL;
> 
> 	Could you please apply it to your tree and forward it to
> Linus (or let me know if you'd prefer to handle it some other way).

Trivially correct, just go ahead and send it to Linus. Thanks.

-- 
Jens Axboe